Re: [PATCH 6/9] cbs: Watch for changes to relevant SIM files.
Hi Andrew,
On 02/15/2011 01:58 AM, Andrzej Zaborowski wrote:
---
src/cbs.c | 32 +++++++++++++++++++++++++++++++-
1 files changed, 31 insertions(+), 1 deletions(-)
Patch has been applied. One more comment below:
@@ -886,7 +888,33 @@ static void sim_cbmid_read_cb(int ok, int
length, int record,
g_free(str);
done:
- cbs_got_file_contents(cbs);
+ if (cbs->efcbmid_update) {
+ topic_str = cbs_topics_to_str(cbs, cbs->topics);
+ cbs->driver->set_topics(cbs, topic_str,
+ cbs_set_powered_cb, cbs);
+ g_free(topic_str);
I think you meant to do this only if CBS atom was powered. I fixed this
under that assumption. Can you double check my logic?
+
+ cbs->efcbmid_update = FALSE;
+ } else
+ cbs_got_file_contents(cbs);
+}
+
Regards,
-Denis