Re: [PATCH v2 4/7] text-telephony: implement interface/atom
Hi Lucas,
>> + tt_set_powered(tt, enable);
>> + tt_send_properties_reply(tt);
>
> The oFono convention is to reply to the pending D-Bus method call and
> then signal the property changed signals.
>
The examples I found for query methods use exactly the opposite. See,
cw_ss_query_callback() in call-settings.c and
radio_fast_dormancy_query_callback() in radio-settings.c.
So we do prefer the reply before the signal. However, we're still a bit
inconsistent in this area because multi-property queries make this very
hard. In the single property case it is doable, but I'm fine accepting
this part as is. So feel free to ignore this feedback.
Regards,
-Denis