Re: [patch 2/6] Generic PPP control protocol
Hi Kristen,
> > +struct pppcp_data;
>
> Why is this needed?
this is needed because we have some circular dependencies in the
pppcp_data structure and the pppcp_actions structure.
you might be absolutely right that this is needed. And it is cleanest
way to do it. However every time I see forward declarations and hear
circular dependencies, I question if the code might not be too complex.
Please keep this in mind. We will revisit this again when doing a deep
down dive review after the merge.
Regards
Marcel