Re: [PATCH] Fix huawei_disconnect function issue
Hi Marcel,
On Fri, Mar 4, 2011 at 8:04 AM, Marcel Holtmann <marcel(a)holtmann.org> wrote:
Anyhow, we need to get rid of the if (cbd == NULL) check first. A
while
back we changed cb_data_new() to use g_new0() instead of g_try_new0() to
simplify the code. So first that should be all cleaned up.
A quick grep showed these locations for the AT modems:
drivers/mbmmodem/location-reporting.c: if (cbd == NULL)
plugins/bluetooth.c: if (cbd == NULL) {
plugins/huawei.c: if (cbd == NULL)
Since git-blame was pointing to me for th mbmmodem and the fix was
really simple, I fixed also the huawei case. bluetooth.c does not
apply here since it uses its own struct cb_data and calls
g_try_new0().
regards,
Lucas De Marchi