Re: [PATCH 2/4] voicecall: api for set/clear alpha and icon id
Hi Jeevaka,
On 07/15/2011 12:24 PM, jeevaka.badrappan(a)linux.intel.com wrote:
Hi Denis,
>> +
>> + number = phone_number_to_string(&req->ph);
>> +
>> + if (!strcmp(number, "112")) {
>> + struct ofono_modem *modem = __ofono_atom_get_modem(vc->atom);
>> +
>> + __ofono_modem_inc_emergency_mode(modem);
>> + }
>
> I think we should do this step in the block of code in
> ofono_voicecall_notify dealing with modem callsetup. See below for more:
Emergency mode for all other dial(user initiated, ofono handled setup
call) has been activated before we issue dial request to modem. Also I
believe its better to activate it here rather than in
ofono_voicecall_notify.
This is debatable since the real world result on the IFX modem is that
we activate emergency mode 15 ms earlier than we otherwise would, but
might cause funny behavior out of our control (for example, if STK
attempts an emergency call while offline, we just flip EmergencyMode to
true & back and go nowhere)
However, in the end I'm fine doing it this way, you just need to make
sure that the logic in clear_alpha_and_icon_id can handle this case.
Regards,
-Denis