[PATCH 2/5] hsomodem: add NULL check

--- drivers/hsomodem/radio-settings.c | 15 ++++++++++----- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/hsomodem/radio-settings.c b/drivers/hsomodem/radio-settings.c index cefd415..a761d44 100644 --- a/drivers/hsomodem/radio-settings.c +++ b/drivers/hsomodem/radio-settings.c @@ -103,11 +103,13 @@ static void hso_query_rat_mode(struct ofono_radio_settings *rs, struct radio_settings_data *rsd = ofono_radio_settings_get_data(rs); struct cb_data *cbd = cb_data_new(cb, data); - if (g_at_chat_send(rsd->chat, "AT_OPSYS?", opsys_prefix, - opsys_query_cb, cbd, g_free) == 0) { - CALLBACK_WITH_FAILURE(cb, -1, data); - g_free(cbd); - } + if (cbd && g_at_chat_send(rsd->chat, "AT_OPSYS?", opsys_prefix, + opsys_query_cb, cbd, g_free) > 0) + return; + + g_free(cbd); + + CALLBACK_WITH_FAILURE(cb, -1, data); } static void opsys_modify_cb(gboolean ok, GAtResult *result, gpointer user_data) @@ -130,6 +132,9 @@ static void hso_set_rat_mode(struct ofono_radio_settings *rs, char buf[20]; int value = 5; + if (cbd == NULL) + goto error; + switch (mode) { case OFONO_RADIO_ACCESS_MODE_ANY: value = 5; -- 1.7.0.4