Hi Rajesh,
Yes, this is a bug. But rather than setting the DCS to default in
this case, we should rather not call that sms_dcs_decode() function
from ofono_sms_status_notify(), as the class information derived from
the DCS decoding is not used there and also we are not handling the
optional text information in the status report handling currently.
It is still a bug that should be fixed ;)
If we decide to handle this optional text information (most likely not
going to happen), then some modifications are required.
Also there is another bug in the current code which might not be
relevant
if we decide to remove the sms_dcs_decode() function call from
ofono_sms_status_notify(). In that function call instead of passing
s.status_report.dcs, we are currently passing s.deliver.dcs.
That is a good catch. We should actually check the DCS to filter out
any malformed status reports.
Anyway, both issues should now be fixed with commits:
c5a42cfabe3abe0d99299daffbe04c33a217fb25
ac72349017fbfdecbba000c0259cc6b99f0873ed
Please test and report back whether the issues persist.
Regards,
-Denis