Re: [PATCH 1/4] atmodem/sim.c: Pass allowed response prefixes to gatchat.
Hi Andrew,
Not doing this creates a race condition where any notification
comming in in the middle of a sequence of commands may be counted
as a response to one of the commands and get lost.
Instead gatchat could be changed to give priority to registered
unsolicited responses if a line matches one of the registered
prefixes, especially since some non-compliant modems regularly
send unsolicited responses in the middle of a command response.
This is why I invented prefixes in GAtChat. Giving higher priority to
unsolicited notifications didn't really work in the case of CGREG/CREG or other
commands which share the same prefix on a response and unsolicited notification.
Calypso is 'fun' in that respect, as you're finding out now ;)
---
drivers/atmodem/sim.c | 15 +++++++++------
1 files changed, 9 insertions(+), 6 deletions(-)
Patch has been applied, thanks.
Regards,
-Denis