11:04 p.m.
Hi,
Issue seen in error handling of read file information request.
This patch should fix that issue.
Regards,
jeevaka
11:04 p.m.
New subject: [PATCH] simfs: Fix issue with sim_fs_op_error
---
src/simfs.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/simfs.c b/src/simfs.c
index 4204aca..1e71f82 100644
--- a/src/simfs.c
+++ b/src/simfs.c
@@ -142,7 +142,10 @@ static void sim_fs_op_error(struct sim_fs *fs)
{
struct sim_fs_op *op = g_queue_peek_head(fs->op_q);
- if (op->is_read == TRUE)
+ if (op->info_only == TRUE)
+ ((sim_fs_read_info_cb_t) op->cb)
+ (0, 0, 0, 0, op->userdata);
+ else if (op->is_read == TRUE)
((ofono_sim_file_read_cb_t) op->cb)
(0, 0, 0, 0, 0, op->userdata);
else
--
1.7.0.4
1:13 a.m.
New subject: [PATCH] simfs: Fix issue with sim_fs_op_error
Hi Jeevaka,
On 10/24/2010 07:04 AM, Jeevaka Badrappan wrote:
---
src/simfs.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/simfs.c b/src/simfs.c
index 4204aca..1e71f82 100644
--- a/src/simfs.c
+++ b/src/simfs.c
@@ -142,7 +142,10 @@ static void sim_fs_op_error(struct sim_fs *fs)
{
struct sim_fs_op *op = g_queue_peek_head(fs->op_q);
- if (op->is_read == TRUE)
+ if (op->info_only == TRUE)
+ ((sim_fs_read_info_cb_t) op->cb)
+ (0, 0, 0, 0, op->userdata);
+ else if (op->is_read == TRUE)
((ofono_sim_file_read_cb_t) op->cb)
(0, 0, 0, 0, 0, op->userdata);
else
Good catch. Patch has been applied, thanks.
Regards,
-Denis
4347
days inactive
4347
days old
2 comments
2 participants
participants (2)
-
Denis Kenzior -
Jeevaka Badrappan