Hi John, On 11/10/2010 06:25 AM, John Mathew wrote: We have pretty strict git apply settings in effect, so your patch does not apply: Applying: TODO: Add owner to extend the voicecall interface with a property indicating emergency call /home/denkenz/ofono-master/.git/rebase-apply/patch:14: trailing whitespace. Owner: John Mathew <john.mathew(a)elektrobit.com&gt; fatal: 1 line adds whitespace errors. Patch failed at 0001 TODO: Add owner to extend the voicecall interface with a property indicating emergency call Also, please keep your commit header under 50 characters. And yes, I know the task description is rather 'long' in this case ;) So sometimes we have to be a bit 'creative'. Something like: "TODO: Assign Voicecall emergency property task" would work in this case. Regards, -Denis

--- TODO | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/TODO b/TODO index eefa605..bf2305b 100644 --- a/TODO +++ b/TODO @@ -422,7 +422,7 @@ Emergency Calls Priority: High Complexity: C1 - + Owner: John Mathew <john.mathew(a)elektrobit.com&gt; Miscellaneous ============= -- 1.7.0.4