8:15 p.m.
Hi,
On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:
CC drivers/mbimmodem/mbim-message.o
drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’:
drivers/mbimmodem/mbim-message.c:199:18: error: cast increases required
alignment of target type [-Werror=cast-align]
uint16_t *le = (uint16_t *) buf;
^
Does the attached patch fix this?
Regards,
-Denis
9:52 a.m.
Hi Denis,
On 08/02/2019 21.15, Denis Kenzior wrote:
Hi,
On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:
> CC drivers/mbimmodem/mbim-message.o
> drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’:
> drivers/mbimmodem/mbim-message.c:199:18: error: cast increases
> required alignment of target type [-Werror=cast-align]
> uint16_t *le = (uint16_t *) buf;
> ^
Does the attached patch fix this?
It fixes it for me. Please apply.
// Martin
5:48 p.m.
Hi Martin,
On 06/21/2019 04:52 AM, Martin Hundebøll wrote:
Hi Denis,
On 08/02/2019 21.15, Denis Kenzior wrote:
> Hi,
>
> On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:
>> CC drivers/mbimmodem/mbim-message.o
>> drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’:
>> drivers/mbimmodem/mbim-message.c:199:18: error: cast increases
>> required alignment of target type [-Werror=cast-align]
>> uint16_t *le = (uint16_t *) buf;
>> ^
>
> Does the attached patch fix this?
It fixes it for me. Please apply.
// Martin
All right, applied.
Regards,
-Denis
5:40 a.m.
Hi Denis,
>> On 02/04/2019 04:28 PM, Pičugins Arsenijs wrote:
>>> CC drivers/mbimmodem/mbim-message.o
>>> drivers/mbimmodem/mbim-message.c: In function ‘_iter_copy_string’:
>>> drivers/mbimmodem/mbim-message.c:199:18: error: cast increases required
alignment of target type [-Werror=cast-align]
>>> uint16_t *le = (uint16_t *) buf;
>>> ^
>>
>> Does the attached patch fix this?
> It fixes it for me. Please apply.
> // Martin
All right, applied.
I wonder if using l_get_u16 here to ensure that we always get the alignment right isn’t
better.
Regards
Marcel
853
days inactive
991
days old
4 comments
4 participants
participants (4)
-
Denis Kenzior -
Marcel Holtmann -
Martin Hundebøll -
Pičugins Arsenijs