8:31 a.m.
Hi All,
I have re-organized the directory structure inside phonesim for easy
management of respective files. Everything was in src directory and as
the simulator will grow in functionality, it will become all the more
cluttered and not so pretty to handle. I have updated the Makefile.am
to reflect the changes and have also tested most of the phonesim
functionality.
I have also added a HACKING file for people to quickly understand and
grasp the concept and execution of phonesim.
Sorry for the size of the patch. It basically increased because of the
moving around of files. Hope it is not much of a problem. Please
review and feedback.
--
BR; Naresh
visit me at:
http://www.naresh.se/
12:46 p.m.
Hi Naresh,
I have re-organized the directory structure inside phonesim for easy
management of respective files. Everything was in src directory and as
the simulator will grow in functionality, it will become all the more
cluttered and not so pretty to handle. I have updated the Makefile.am
to reflect the changes and have also tested most of the phonesim
functionality.
actually all the includes are local to phonesim and that is why they are
inside the src/ directory.
I also don't see the clutter you are talking about. The *.h are named
the same as their *.cpp files and are side by side. I actually call that
pretty clean.
I have also added a HACKING file for people to quickly understand
and
grasp the concept and execution of phonesim.
Please send that as a separate patch.
Regards
Marcel
6:59 p.m.
On Fri, May 28, 2010 at 4:46 AM, Marcel Holtmann <marcel(a)holtmann.org> wrote:
Hi Naresh,
actually all the includes are local to phonesim and that is why they are
inside the src/ directory.
I also don't see the clutter you are talking about. The *.h are named
the same as their *.cpp files and are side by side. I actually call that
pretty clean.
Hi Marcel,
I generally prefer to keep the header files separate then the actual
source files. I had also
moved the xml files into an xml folder. But I have now reverted those changes.
> I have also added a HACKING file for people to quickly understand
and
> grasp the concept and execution of phonesim.
Please send that as a separate patch.
Patch file for HACKING attached.
--
BR; Naresh
visit me at:
http://www.naresh.se/
7:56 p.m.
Hi Naresh,
I generally prefer to keep the header files separate then the actual
source files. I had also
moved the xml files into an xml folder. But I have now reverted those changes.
>> I have also added a HACKING file for people to quickly understand and
>> grasp the concept and execution of phonesim.
>
> Please send that as a separate patch.
Patch file for HACKING attached.
please create patches with git format-patch and make sure the commit
message is split in a subject and body. Also check that it applies
cleanly with git am. Your current patch doesn't. So please redo this and
send it again.
Also I prefer to get patches inline. It is not a hard requirement, but
makes things a lot easier. Using git send-email is helpful here.
Regards
Marcel
4:57 p.m.
New subject: [Patch]: Reducing clutter in the src directory + Introduction of HACKING file
Naresh Mehta <nareshtechs(a)gmail.com> writes:
Sorry for the size of the patch. It basically increased because of
the
moving around of files. Hope it is not much of a problem.
A git tip of the day:
git format-patch has switch -M which enables rename detection. It should
make patches like this a lot smaller.
--
Kalle Valo
6:40 p.m.
On Fri, May 28, 2010 at 8:57 AM, Kalle Valo <kalle.valo(a)canonical.com> wrote:
A git tip of the day:
git format-patch has switch -M which enables rename detection. It should
make patches like this a lot smaller.
--
Kalle Valo
Thanks for the tip Kalle. I will keep that in mind.
--
BR; Naresh
visit me at:
http://www.naresh.se/
4495
days inactive
4497
days old
5 comments
3 participants
participants (3)
-
Kalle Valo -
Marcel Holtmann -
Naresh Mehta