11:42 p.m.
Setting AT+COLP=1 on the SIMCom SIM7100E causes oFono to stall and not
create a new VoiceCall object. We fix that by adding the SIMCOM
vendor ID to the list for whom we set AT+COLP=0 instead.
Bob Ham (2):
atmodem: Don't set AT+COLP=1 on SIMCom modems
sim7100: Specify vendor ID while creating voicecall driver
drivers/atmodem/voicecall.c | 1 +
plugins/sim7100.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.11.0
11:42 p.m.
New subject: [PATCH 1/2] atmodem: Don't set AT+COLP=1 on SIMCom modems
On the SIMCom SIM7100E, setting AT+COLP=1 causes there to be no
response at all from "ATD...;" commands until the call is answered.
The results in oFono stalling rather than creating a new VoiceCall
object.
We fix this by adding SIMCOM to the list of vendors for whom we set
AT+COLP=0 rather than AT+COLP=1.
---
drivers/atmodem/voicecall.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c
index e4c59c26..aa56f1ee 100644
--- a/drivers/atmodem/voicecall.c
+++ b/drivers/atmodem/voicecall.c
@@ -1120,6 +1120,7 @@ static int at_voicecall_probe(struct ofono_voicecall *vc, unsigned
int vendor,
switch (vd->vendor) {
case OFONO_VENDOR_QUALCOMM_MSM:
+ case OFONO_VENDOR_SIMCOM:
g_at_chat_send(vd->chat, "AT+COLP=0", NULL, NULL, NULL, NULL);
break;
default:
--
2.11.0
11:42 p.m.
New subject: [PATCH 2/2] sim7100: Specify vendor ID while creating voicecall driver
This enables the atmodem voicecall driver to handle SIMCom quirks like
not setting AT+COLP=1.
---
plugins/sim7100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/sim7100.c b/plugins/sim7100.c
index dcd7c9ad..7c7e46d1 100644
--- a/plugins/sim7100.c
+++ b/plugins/sim7100.c
@@ -214,7 +214,7 @@ static void sim7100_pre_sim(struct ofono_modem *modem)
ofono_devinfo_create(modem, 0, "atmodem", data->at);
sim = ofono_sim_create(modem, 0, "atmodem", data->at);
- ofono_voicecall_create(modem, 0, "atmodem", data->at);
+ ofono_voicecall_create(modem, OFONO_VENDOR_SIMCOM, "atmodem", data->at);
if (sim)
ofono_sim_inserted_notify(sim, TRUE);
--
2.11.0
1588
days inactive
1588
days old
3 comments
2 participants
participants (2)
-
Bob Ham -
Denis Kenzior