10:11 p.m.
Hi,
Those 2 patches added dormant notification support for SpeedUp CDMA modems.
The prefix used for notification is the same as Huawei modem one.
Kind regards,
Guillaume
Guillaume Zajac (2):
cdmamodem: Support speedup dormant notification
speedupcdma: Tweak plugin to notify dormant state
drivers/cdmamodem/connman.c | 5 +++++
plugins/speedupcdma.c | 7 ++++++-
2 files changed, 11 insertions(+), 1 deletions(-)
10:11 p.m.
New subject: [PATCH 1/2] cdmamodem: Support speedup dormant notification
---
drivers/cdmamodem/connman.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/cdmamodem/connman.c b/drivers/cdmamodem/connman.c
index 8c3265a..41708f7 100644
--- a/drivers/cdmamodem/connman.c
+++ b/drivers/cdmamodem/connman.c
@@ -264,6 +264,11 @@ static void at_c0_cb(gboolean ok, GAtResult *result, gpointer
user_data)
}
switch (cd->vendor) {
+ case OFONO_VENDOR_SPEEDUP:
+ /*
+ * Fall through: SpeedUp modem uses same prefix as Huawei
+ * modem for dormant notification.
+ */
case OFONO_VENDOR_HUAWEI:
chat = g_at_chat_get_slave(cd->chat);
g_at_chat_register(chat, "^DSDORMANT", huawei_dsdormant_notify,
--
1.7.1
10:33 a.m.
New subject: [PATCH 1/2] cdmamodem: Support speedup dormant notification
Hi Guillaume,
On 12/12/2011 05:11 AM, Guillaume Zajac wrote:
---
drivers/cdmamodem/connman.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/cdmamodem/connman.c b/drivers/cdmamodem/connman.c
index 8c3265a..41708f7 100644
--- a/drivers/cdmamodem/connman.c
+++ b/drivers/cdmamodem/connman.c
@@ -264,6 +264,11 @@ static void at_c0_cb(gboolean ok, GAtResult *result, gpointer
user_data)
}
switch (cd->vendor) {
+ case OFONO_VENDOR_SPEEDUP:
+ /*
+ * Fall through: SpeedUp modem uses same prefix as Huawei
+ * modem for dormant notification.
+ */
If the handling is exactly the same, then it is better to just skip this
step. Using OFONO_VENDOR_HUAWEI from the speedup plugin is just fine.
case OFONO_VENDOR_HUAWEI:
chat = g_at_chat_get_slave(cd->chat);
g_at_chat_register(chat, "^DSDORMANT", huawei_dsdormant_notify,
Regards,
-Denis
10:11 p.m.
New subject: [PATCH 2/2] speedupcdma: Tweak plugin to notify dormant state
---
plugins/speedupcdma.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/plugins/speedupcdma.c b/plugins/speedupcdma.c
index 3b398aa..b43e008 100644
--- a/plugins/speedupcdma.c
+++ b/plugins/speedupcdma.c
@@ -37,6 +37,8 @@
#include <ofono/cdma-connman.h>
#include <ofono/log.h>
+#include "drivers/atmodem/vendor.h"
+
struct speedupcdma_data {
GAtChat *modem;
GAtChat *aux;
@@ -146,6 +148,8 @@ static int speedupcdma_enable(struct ofono_modem *modem)
return -EIO;
}
+ g_at_chat_set_slave(data->modem, data->aux);
+
g_at_chat_send(data->modem, "ATE0 &C0 +CMEE=1", NULL, NULL, NULL,
NULL);
g_at_chat_send(data->aux, "ATE0 &C0 +CMEE=1", NULL, NULL, NULL, NULL);
@@ -210,7 +214,8 @@ static void speedupcdma_post_online(struct ofono_modem *modem)
DBG("%p", modem);
- ofono_cdma_connman_create(modem, 0, "cdmamodem", data->modem);
+ ofono_cdma_connman_create(modem, OFONO_VENDOR_SPEEDUP, "cdmamodem",
+ data->modem);
}
static struct ofono_modem_driver speedupcdma_driver = {
--
1.7.1
3935
days inactive
3933
days old
3 comments
2 participants
participants (2)
-
Denis Kenzior -
Guillaume Zajac