7:14 p.m.
Hi,
Attached patch is the Bluetooth handsfree profile (HFP) support for oFono. It
includes hfp plugin and the basic driver backend framework. The plugin use
'AT+BRSF=118' to inform AG supported features and perform serivce level
connection in modem's power on stage. The voicecall driver for HFP is planed
to add later. Handsfree profile actually need BlueZ support for SCO connection
for routing audio which is not in this patch.
You may need to create /dev/rfcomm0 through 'rfcomm bind <port> <bdaddr>
<channel>' and then specify device in modem.conf. For example,
rfcomm bind 0 00:22:A9:8C:AF:34 2
The channel number of HFP audio gateway could be found though 'sdptool browse'
result.
Regards,
Zhenhua
4:47 a.m.
New subject: fix handsfree profile patch
Hi Zhenhua,
This patch fix compiler warnings into your HFP patch. I didn't looked to the code and
what it does yet.
Regards,
Gustavo
4:47 a.m.
New subject: [PATCH 1/1] fix handsfree profile to compile with --enable-maintainer-mode
this is all about compile-warnings.
---
drivers/hfpmodem/hfp.c | 2 +-
drivers/hfpmodem/hfp.h | 2 +-
plugins/hfp.c | 4 ----
3 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/hfpmodem/hfp.c b/drivers/hfpmodem/hfp.c
index 941e7b1..69e2f64 100644
--- a/drivers/hfpmodem/hfp.c
+++ b/drivers/hfpmodem/hfp.c
@@ -40,7 +40,6 @@
#include "hfp.h"
-static const char *none_prefix[] = { NULL };
static const char *brsf_prefix[] = { "+BRSF:", NULL };
static const char *cind_prefix[] = { "+CIND:", NULL };
static const char *cmer_prefix[] = { "+CMER:", NULL };
@@ -337,6 +336,7 @@ GAtChat *hfp_get_chat(gpointer user_data)
static int hfpmodem_init(void)
{
+ return 0;
}
static void hfpmodem_exit(void)
diff --git a/drivers/hfpmodem/hfp.h b/drivers/hfpmodem/hfp.h
index fa5641f..5a98c3d 100644
--- a/drivers/hfpmodem/hfp.h
+++ b/drivers/hfpmodem/hfp.h
@@ -71,7 +71,7 @@ struct gateway {
HfpConnectFunc conn_cb;
gpointer cb_data;
- unsigned int ag_features;
+ int ag_features;
unsigned int mpty_features;
GSList *indies;
};
diff --git a/plugins/hfp.c b/plugins/hfp.c
index c73a032..1a7f064 100644
--- a/plugins/hfp.c
+++ b/plugins/hfp.c
@@ -187,15 +187,11 @@ static int hfp_disable(struct ofono_modem *modem)
static void hfp_pre_sim(struct ofono_modem *modem)
{
- struct hfp_data *hfp_data = ofono_modem_get_data(modem);
-
DBG("%p", modem);
}
static void hfp_post_sim(struct ofono_modem *modem)
{
- struct hfp_data *hfp_data = ofono_modem_get_data(modem);
-
DBG("%p", modem);
}
--
1.6.4.4
1:55 p.m.
New subject: fix handsfree profile patch
Hi Padovan,
Gustavo F. Padovan wrote:
Hi Zhenhua,
This patch fix compiler warnings into your HFP patch. I didn't looked
to the code and what it does yet.
Thanks for your patch. I will turn on the maintainer mode from now on.
Regards,
Gustavo
Regards,
Zhenhua
4719
days inactive
4722
days old
3 comments
2 participants
participants (2)
-
Gustavo F. Padovan -
Zhang, Zhenhua