3:54 a.m.
On huawei E3372, context id can be 0:
AT+CGDCONT=?
+CGDCONT: (0-31),"IP",,,(0-2),(0-3),(0,1),(0,1),(0-2),(0,1)
+CGDCONT: (0-31),"IPV6",,,(0-2),(0-3),(0,1),(0,1),(0-2),(0,1)
+CGDCONT: (0-31),"IPV4V6",,,(0-2),(0-3),(0,1),(0,1),(0-2),(0,1)
+CGDCONT: (0-31),"PPP",,,(0-2),(0-3),(0,1),(0,1),(0-2),(0,1)
OK
During first time activation, gprs_cid_alloc (and idmap_alloc)
will return 0 as context id. This is not an error.
Christophe Ronco (1):
gprs: fix error check of gprs_cid_alloc function
src/gprs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.11.0
3:54 a.m.
New subject: [PATCH 1/1] gprs: fix error check of gprs_cid_alloc function
When there is no context id available, idmap_alloc and
gprs_cid_alloc return max + 1.
---
src/gprs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gprs.c b/src/gprs.c
index 5015a2fc..6ed1c89d 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -313,7 +313,7 @@ static gboolean assign_context(struct pri_context *ctx, int use_cid)
} else
ctx->context.cid = gprs_cid_alloc(ctx->gprs);
- if (ctx->context.cid == 0)
+ if (ctx->context.cid > idmap_get_max(cidmap))
return FALSE;
for (l = ctx->gprs->context_drivers; l; l = l->next) {
--
2.11.0
7:40 a.m.
New subject: [PATCH 1/1] gprs: fix error check of gprs_cid_alloc function
Hi Christophe,
On 02/15/2017 10:54 AM, Christophe Ronco wrote:
When there is no context id available, idmap_alloc and
gprs_cid_alloc return max + 1.
---
src/gprs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Regards,
-Denis
2041
days inactive
2041
days old
2 comments
2 participants
participants (2)
-
Christophe Ronco -
Denis Kenzior