Hi Minjun, On Monday 01 June 2009 20:18:23 Li, Minjun wrote: Please use proper coding style when submitting patches. This means tabs instead of spaces, and proper spacing, e.g. 'if () {' The functions should be named appropriately, 'foo_free' just won't work. Also, only include patches that are specific to the fix, things like mode change are extraneous. And include a proper commit message. Regards, -Denis

Hi Martin, Thanks for your kind help! Best Regards, Minjun -----Original Message----- From: ofono-bounces(a)ofono.org [mailto:ofono-bounces@ofono.org] On Behalf Of Xu, Martin Sent: 2009年6月3日 10:25 To: ofono(a)ofono.org Subject: RE: add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called Hi Mingjun: Since it uses the kernel coding style, you can use checkpatch.pl from kernel to check your patch before you submit it. :) I have attached the script in my attachment in case you are not familiar with kernel. -----Original Message----- From: ofono-bounces(a)ofono.org [mailto:ofono-bounces@ofono.org] On Behalf Of Denis Kenzior Sent: 2009年6月2日 11:58 To: ofono(a)ofono.org Subject: Re: add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called Hi Minjun, On Monday 01 June 2009 20:18:23 Li, Minjun wrote: Please use proper coding style when submitting patches. This means tabs instead of spaces, and proper spacing, e.g. 'if () {' The functions should be named appropriately, 'foo_free' just won't work. Also, only include patches that are specific to the fix, things like mode change are extraneous. And include a proper commit message. Regards, -Denis _______________________________________________ ofono mailing list ofono(a)ofono.org http://lists.ofono.org/listinfo/ofono