10:42 p.m.
Hi,
If ofono is started before setting the LANG enviroment variable, then
call to getenv fails. This results in the failure of test case
Provide Local Information - Language setting(27.22.4.15 seq 1.5).
Plan is to default to en when the getenv fails. Warning message has
also been added. Distribution will be informed to start ofono after
the locale is set.
Regards,
Jeevaka
Jeevaka Badrappan (1):
stk: Fix getenv failure case
src/stk.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
10:42 p.m.
New subject: [PATCH 1/1] stk: Fix getenv failure case
---
src/stk.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/stk.c b/src/stk.c
index 68b6240..94ad396 100644
--- a/src/stk.c
+++ b/src/stk.c
@@ -2177,8 +2177,9 @@ static void get_lang(struct stk_response *rsp, struct ofono_stk
*stk)
l = getenv("LANG");
if (l == NULL) {
- rsp->result.type = STK_RESULT_TYPE_NOT_CAPABLE;
- goto out;
+ l = "en";
+ ofono_warn("LANG environment variable not set"
+ " - defaulting to en");
}
memcpy(lang, l, 2);
@@ -2187,7 +2188,6 @@ static void get_lang(struct stk_response *rsp, struct ofono_stk
*stk)
rsp->result.type = STK_RESULT_TYPE_SUCCESS;
rsp->provide_local_info.language = lang;
-out:
if (stk_respond(stk, rsp, stk_command_cb))
stk_command_cb(&failure, stk);
}
--
1.7.0.4
4197
days inactive
4197
days old
2 comments
2 participants
participants (2)
-
Denis Kenzior -
Jeevaka Badrappan