3:40 p.m.
Hi,
These patches concern mmsd for ofono mailing list.
Sébastien Bianti (2):
service: transaction id should'nt be NULL
TODO: storage task complete
TODO | 14 --------------
src/service.c | 6 ++++--
2 files changed, 4 insertions(+), 16 deletions(-)
--
1.7.4.4
3:40 p.m.
New subject: [PATCH 1/2] service: transaction id should'nt be NULL
It is not contained in an automatic retrieve_conf pdu.
---
src/service.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/service.c b/src/service.c
index 755ebc3..f148252 100644
--- a/src/service.c
+++ b/src/service.c
@@ -998,9 +998,11 @@ static gboolean load_message_from_store(const char *service_id,
else
msg->rc.status = MMS_MESSAGE_STATUS_RECEIVED;
} else if (strcmp(state, "downloaded") == 0
- && msg->type == MMS_MESSAGE_TYPE_RETRIEVE_CONF)
+ && msg->type == MMS_MESSAGE_TYPE_RETRIEVE_CONF) {
msg->rc.status = MMS_MESSAGE_STATUS_DOWNLOADED;
- else if (strcmp(state, "sent") == 0
+ if (msg->transaction_id == NULL)
+ msg->transaction_id = "";
+ } else if (strcmp(state, "sent") == 0
&& msg->type == MMS_MESSAGE_TYPE_SEND_REQ)
msg->sr.status = MMS_MESSAGE_STATUS_SENT;
else if (strcmp(state, "draft") == 0
--
1.7.4.4
3:40 p.m.
New subject: [PATCH 2/2] TODO: storage task complete
---
TODO | 14 --------------
1 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/TODO b/TODO
index 42e25a6..c75468d 100644
--- a/TODO
+++ b/TODO
@@ -43,20 +43,6 @@ MMS Reception
support.
Owner: Ronald Tessier <ronald.tessier(a)linux.intel.com>
-MMS Storage
-===========
-
-- Add pending/incompleted transactions recovery on mmsd restart.
- In the case of a restart of the mmsd, all the incomplete/pending MMS
- transactions identified thanks to the META file information
- (status key value) should be re-processed (i.e.: added to the mms_service
- structure request_queue).
-
- Priority: Medium
- Complexity: C2
- Depends: META file support, MMS submit support.
- Owner: Sebastien Bianti <sebastien.bianti(a)linux.intel.com>
-
D-Bus API
=========
--
1.7.4.4
3463
days inactive
3463
days old
3 comments
2 participants
participants (2)
-
Marcel Holtmann -
Sébastien Bianti