Hi George,
2011/2/6 George Matveev <george(a)matveev.se>:
Introduce enum network_timeout for scan/registration timeouts,
remove unused NETWORK_TIMEOUT.
---
drivers/isimodem/network.h | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/isimodem/network.h b/drivers/isimodem/network.h
index b96216d..f35ed5a 100644
--- a/drivers/isimodem/network.h
+++ b/drivers/isimodem/network.h
@@ -27,11 +27,13 @@ extern "C" {
#endif
#define PN_NETWORK 0x0A
-#define NETWORK_TIMEOUT 5
-#define NETWORK_SCAN_TIMEOUT 180
-#define NETWORK_SET_TIMEOUT 240
#define NET_INVALID_TIME 0x64
I would rather just remove the unused define.
+enum network_timeout {
+ NETWORK_SCAN_TIMEOUT = 180,
+ NETWORK_SET_TIMEOUT = 240
This is not the indentation style to use for enums. Check
coding-style.txt, section M11.
Cheers,
Aki