6:25 p.m.
---
plugins/speedup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/plugins/speedup.c b/plugins/speedup.c
index 90ca5e3..a7aa43c 100644
--- a/plugins/speedup.c
+++ b/plugins/speedup.c
@@ -177,7 +177,7 @@ static int speedup_enable(struct ofono_modem *modem)
g_at_chat_send(data->modem, "ATE0 &C0 +CMEE=1", NULL, NULL, NULL,
NULL);
g_at_chat_send(data->aux, "ATE0 &C0 +CMEE=1", NULL, NULL, NULL, NULL);
- g_at_chat_send(data->aux, "AT+CFUN=1", NULL,
+ g_at_chat_send(data->aux, "AT+CFUN=4", NULL,
cfun_enable, modem, NULL);
return -EINPROGRESS;
--
1.7.4.1
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
9:18 p.m.
Hi Bertrand,
plugins/speedup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/plugins/speedup.c b/plugins/speedup.c
index 90ca5e3..a7aa43c 100644
--- a/plugins/speedup.c
+++ b/plugins/speedup.c
@@ -177,7 +177,7 @@ static int speedup_enable(struct ofono_modem *modem)
g_at_chat_send(data->modem, "ATE0 &C0 +CMEE=1", NULL, NULL, NULL,
NULL);
g_at_chat_send(data->aux, "ATE0 &C0 +CMEE=1", NULL, NULL, NULL,
NULL);
- g_at_chat_send(data->aux, "AT+CFUN=1", NULL,
+ g_at_chat_send(data->aux, "AT+CFUN=4", NULL,
cfun_enable, modem, NULL);
this is not a correct fix. You are messing up the logic here. You are
still in offline mode from an oFono point of view, but your modem is
actually online.
Try the same that we did for ZTE with sending +CFUN=1;+CFUN=4 if that
works out.
If not, then check if we can go CFUN=1 first and then after SIM query
succeeded, we go into CFUN=4. We do this for Huawei actually.
If none of these work, then you need to remove the set_online callback
like we do for Nokia. If you can not support online/offline mode, then
don't even try to.
And please show proper OFONO_AT_DEBUG traces. They can be part of the
commit message actually.
Regards
Marcel
9:59 p.m.
Hi,
> plugins/speedup.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/plugins/speedup.c b/plugins/speedup.c
> index 90ca5e3..a7aa43c 100644
> --- a/plugins/speedup.c
> +++ b/plugins/speedup.c
> @@ -177,7 +177,7 @@ static int speedup_enable(struct ofono_modem *modem)
> g_at_chat_send(data->modem, "ATE0 &C0 +CMEE=1", NULL, NULL,
NULL,
NULL);
> g_at_chat_send(data->aux, "ATE0 &C0 +CMEE=1", NULL, NULL, NULL,
NULL);
>
> - g_at_chat_send(data->aux, "AT+CFUN=1", NULL,
> + g_at_chat_send(data->aux, "AT+CFUN=4", NULL,
> cfun_enable, modem, NULL);
this is not a correct fix. You are messing up the logic here. You are
still in offline mode from an oFono point of view, but your modem is
actually online.
Try the same that we did for ZTE with sending +CFUN=1;+CFUN=4 if that
works out.
This is not working:
ofonod[17315]: plugins/speedup.c:speedup_enable() 0x9ae1af8
ofonod[17315]: src/modem.c:get_modem_property() modem 0x9ae1af8 property Modem
ofonod[17315]: plugins/speedup.c:open_device() Modem /dev/ttyUSB1
ofonod[17315]: src/modem.c:get_modem_property() modem 0x9ae1af8 property Aux
ofonod[17315]: plugins/speedup.c:open_device() Aux /dev/ttyUSB2
ofonod[17315]: Modem: > ATE0 +CMEE=1\r
ofonod[17315]: Aux: > ATE0 +CMEE=1\r
ofonod[17315]: Aux: < ATE0 +CMEE=1\r
ofonod[17315]: Modem: < \r\nOK\r\n
ofonod[17315]: Aux: < \r\nOK\r\n
ofonod[17315]: Aux: > AT+CFUN=1;+CFUN=4\r
ofonod[17315]: Aux: < \r\n+CME ERROR: 0\r\n
ofonod[17315]: plugins/speedup.c:cfun_enable()
If not, then check if we can go CFUN=1 first and then after SIM
query
succeeded, we go into CFUN=4. We do this for Huawei actually.
I will try this...
If none of these work, then you need to remove the set_online
callback
like we do for Nokia. If you can not support online/offline mode, then
don't even try to.
And please show proper OFONO_AT_DEBUG traces. They can be part of the
commit message actually.
Regards,
Bertrand
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
11 p.m.
Hi Marcel,
> > plugins/speedup.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/plugins/speedup.c b/plugins/speedup.c
> > index 90ca5e3..a7aa43c 100644
> > --- a/plugins/speedup.c
> > +++ b/plugins/speedup.c
> > @@ -177,7 +177,7 @@ static int speedup_enable(struct ofono_modem *modem)
> > g_at_chat_send(data->modem, "ATE0 &C0 +CMEE=1", NULL, NULL,
NULL,
> NULL);
> > g_at_chat_send(data->aux, "ATE0 &C0 +CMEE=1", NULL, NULL,
NULL, NULL);
> >
> > - g_at_chat_send(data->aux, "AT+CFUN=1", NULL,
> > + g_at_chat_send(data->aux, "AT+CFUN=4", NULL,
> > cfun_enable, modem, NULL);
>
> this is not a correct fix. You are messing up the logic here. You are
> still in offline mode from an oFono point of view, but your modem is
> actually online.
>
> Try the same that we did for ZTE with sending +CFUN=1;+CFUN=4 if that
> works out.
This is not working:
ofonod[17315]: plugins/speedup.c:speedup_enable() 0x9ae1af8
ofonod[17315]: src/modem.c:get_modem_property() modem 0x9ae1af8 property Modem
ofonod[17315]: plugins/speedup.c:open_device() Modem /dev/ttyUSB1
ofonod[17315]: src/modem.c:get_modem_property() modem 0x9ae1af8 property Aux
ofonod[17315]: plugins/speedup.c:open_device() Aux /dev/ttyUSB2
ofonod[17315]: Modem: > ATE0 +CMEE=1\r
ofonod[17315]: Aux: > ATE0 +CMEE=1\r
ofonod[17315]: Aux: < ATE0 +CMEE=1\r
ofonod[17315]: Modem: < \r\nOK\r\n
ofonod[17315]: Aux: < \r\nOK\r\n
ofonod[17315]: Aux: > AT+CFUN=1;+CFUN=4\r
ofonod[17315]: Aux: < \r\n+CME ERROR: 0\r\n
ofonod[17315]: plugins/speedup.c:cfun_enable()
> If not, then check if we can go CFUN=1 first and then after SIM query
> succeeded, we go into CFUN=4. We do this for Huawei actually.
I will try this...
I have attach the log. There is an issue. The AT command just after the CFUN=1 to go
online are failing. I guess that we have to do some timing stuff, because if I use minicom
to send the AT+CREG=? Later, the answer is correct.
> If none of these work, then you need to remove the set_online
callback
> like we do for Nokia. If you can not support online/offline mode, then
> don't even try to.
>
> And please show proper OFONO_AT_DEBUG traces. They can be part of the
> commit message actually.
>
Regards,
Bertrand
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
11:21 p.m.
Hi Bertrand,
> > > plugins/speedup.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/plugins/speedup.c b/plugins/speedup.c
> > > index 90ca5e3..a7aa43c 100644
> > > --- a/plugins/speedup.c
> > > +++ b/plugins/speedup.c
> > > @@ -177,7 +177,7 @@ static int speedup_enable(struct ofono_modem *modem)
> > > g_at_chat_send(data->modem, "ATE0 &C0 +CMEE=1", NULL,
NULL, NULL,
> > NULL);
> > > g_at_chat_send(data->aux, "ATE0 &C0 +CMEE=1", NULL,
NULL, NULL, NULL);
> > >
> > > - g_at_chat_send(data->aux, "AT+CFUN=1", NULL,
> > > + g_at_chat_send(data->aux, "AT+CFUN=4", NULL,
> > > cfun_enable, modem, NULL);
> >
> > this is not a correct fix. You are messing up the logic here. You are
> > still in offline mode from an oFono point of view, but your modem is
> > actually online.
> >
> > Try the same that we did for ZTE with sending +CFUN=1;+CFUN=4 if that
> > works out.
>
> This is not working:
>
> ofonod[17315]: plugins/speedup.c:speedup_enable() 0x9ae1af8
> ofonod[17315]: src/modem.c:get_modem_property() modem 0x9ae1af8 property Modem
> ofonod[17315]: plugins/speedup.c:open_device() Modem /dev/ttyUSB1
> ofonod[17315]: src/modem.c:get_modem_property() modem 0x9ae1af8 property Aux
> ofonod[17315]: plugins/speedup.c:open_device() Aux /dev/ttyUSB2
> ofonod[17315]: Modem: > ATE0 +CMEE=1\r
> ofonod[17315]: Aux: > ATE0 +CMEE=1\r
> ofonod[17315]: Aux: < ATE0 +CMEE=1\r
> ofonod[17315]: Modem: < \r\nOK\r\n
> ofonod[17315]: Aux: < \r\nOK\r\n
> ofonod[17315]: Aux: > AT+CFUN=1;+CFUN=4\r
> ofonod[17315]: Aux: < \r\n+CME ERROR: 0\r\n
> ofonod[17315]: plugins/speedup.c:cfun_enable()
>
>
> > If not, then check if we can go CFUN=1 first and then after SIM query
> > succeeded, we go into CFUN=4. We do this for Huawei actually.
>
> I will try this...
I have attach the log. There is an issue. The AT command just after the CFUN=1 to go
online are failing. I guess that we have to do some timing stuff, because if I use minicom
to send the AT+CREG=? Later, the answer is correct.
actually you can only do set_powered() after the CFUN=4 succeeded. You
need to feed that into your modem enabling procedure.
ofonod[26439]: src/modem.c:modem_change_state() old state: 0, new state: 1
ofonod[26439]: plugins/speedup.c:speedup_pre_sim() 0x8909ae0
ofonod[26439]: Aux: > AT+GCAP\r
ofonod[26439]: src/sim.c:ofono_sim_add_state_watch() 0x890a348
ofonod[26439]: src/sim.c:ofono_sim_add_state_watch() 0x890a348
ofonod[26439]: src/sim.c:ofono_sim_add_state_watch() 0x890a348
ofonod[26439]: Aux: < \r\n+GCAP: +CGSM,+FCLASS,+DS\r\n\r\nOK\r\n
ofonod[26439]: Aux: > AT+CFUN=4\r
ofonod[26439]: Aux: < \r\nOK\r\n
The log clearly shows that you power on the modem before sending CFUN=4.
Try to change that.
Some other comments along the lines for this modem:
ofonod[26439]: Aux: > AT+CSCB=?\r
ofonod[26439]: Aux: < \r\nERROR\r\n
ofonod[26439]: CSCB not supported
Since CBS is not supported, do not even bother creating that atom.
ofonod[26439]: Aux: > AT+CSCS?\r
ofonod[26439]: Aux: < \r\nERROR\r\n
ofonod[26439]: Aux: > AT+CUSD=1\r
ofonod[26439]: Aux: < \r\nERROR\r\n
ofonod[26439]: Could not enable CUSD notifications
Same goes for USSD. That is why I hate blind copies from other modem
plugins.
And I would not be surprised if even SMS is half failing. It takes a lot
of patience to figure out what quirks are needed for what hardware. If
it is not tested, then we rather not enable it in the first place.
Regards
Marcel
11:37 p.m.
Hi Marcel,
> > > > plugins/speedup.c | 2 +-
> > > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/plugins/speedup.c b/plugins/speedup.c
> > > > index 90ca5e3..a7aa43c 100644
> > > > --- a/plugins/speedup.c
> > > > +++ b/plugins/speedup.c
> > > > @@ -177,7 +177,7 @@ static int speedup_enable(struct ofono_modem
*modem)
> > > > g_at_chat_send(data->modem, "ATE0 &C0 +CMEE=1",
NULL, NULL, NULL,
> > > NULL);
> > > > g_at_chat_send(data->aux, "ATE0 &C0 +CMEE=1",
NULL, NULL, NULL,
NULL);
> > > >
> > > > - g_at_chat_send(data->aux, "AT+CFUN=1", NULL,
> > > > + g_at_chat_send(data->aux, "AT+CFUN=4", NULL,
> > > > cfun_enable, modem, NULL);
> > >
> > > this is not a correct fix. You are messing up the logic here. You are
> > > still in offline mode from an oFono point of view, but your modem is
> > > actually online.
> > >
> > > Try the same that we did for ZTE with sending +CFUN=1;+CFUN=4 if that
> > > works out.
> >
> > This is not working:
> >
> > ofonod[17315]: plugins/speedup.c:speedup_enable() 0x9ae1af8
> > ofonod[17315]: src/modem.c:get_modem_property() modem 0x9ae1af8 property
Modem
> > ofonod[17315]: plugins/speedup.c:open_device() Modem /dev/ttyUSB1
> > ofonod[17315]: src/modem.c:get_modem_property() modem 0x9ae1af8 property
Aux
> > ofonod[17315]: plugins/speedup.c:open_device() Aux /dev/ttyUSB2
> > ofonod[17315]: Modem: > ATE0 +CMEE=1\r
> > ofonod[17315]: Aux: > ATE0 +CMEE=1\r
> > ofonod[17315]: Aux: < ATE0 +CMEE=1\r
> > ofonod[17315]: Modem: < \r\nOK\r\n
> > ofonod[17315]: Aux: < \r\nOK\r\n
> > ofonod[17315]: Aux: > AT+CFUN=1;+CFUN=4\r
> > ofonod[17315]: Aux: < \r\n+CME ERROR: 0\r\n
> > ofonod[17315]: plugins/speedup.c:cfun_enable()
> >
> >
> > > If not, then check if we can go CFUN=1 first and then after SIM query
> > > succeeded, we go into CFUN=4. We do this for Huawei actually.
> >
> > I will try this...
>
> I have attach the log. There is an issue. The AT command just after the
CFUN=1 to go online are failing. I guess that we have to do some timing stuff,
because if I use minicom to send the AT+CREG=? Later, the answer is correct.
actually you can only do set_powered() after the CFUN=4 succeeded. You
need to feed that into your modem enabling procedure.
ofonod[26439]: src/modem.c:modem_change_state() old state: 0, new state: 1
ofonod[26439]: plugins/speedup.c:speedup_pre_sim() 0x8909ae0
ofonod[26439]: Aux: > AT+GCAP\r
ofonod[26439]: src/sim.c:ofono_sim_add_state_watch() 0x890a348
ofonod[26439]: src/sim.c:ofono_sim_add_state_watch() 0x890a348
ofonod[26439]: src/sim.c:ofono_sim_add_state_watch() 0x890a348
ofonod[26439]: Aux: < \r\n+GCAP: +CGSM,+FCLASS,+DS\r\n\r\nOK\r\n
ofonod[26439]: Aux: > AT+CFUN=4\r
ofonod[26439]: Aux: < \r\nOK\r\n
The log clearly shows that you power on the modem before sending CFUN=4.
Try to change that.
Some other comments along the lines for this modem:
ofonod[26439]: Aux: > AT+CSCB=?\r
ofonod[26439]: Aux: < \r\nERROR\r\n
ofonod[26439]: CSCB not supported
Since CBS is not supported, do not even bother creating that atom.
As I explained, all those errors are due to the CPIN=1. If we are in CFUN=4, it seems that
we have to wait after sending the CFUN=1 to goes online.
I have attached a full log with only CFUN=1 and no CFUN=4. I have replaced the CFUN=4 by a
CFUN=1.
You will see that CBS is supported, USSD also...
Regards,
Bertrand
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
11:44 p.m.
Hi Bertrand,
> Some other comments along the lines for this modem:
>
> ofonod[26439]: Aux: > AT+CSCB=?\r
> ofonod[26439]: Aux: < \r\nERROR\r\n
> ofonod[26439]: CSCB not supported
>
> Since CBS is not supported, do not even bother creating that atom.
As I explained, all those errors are due to the CPIN=1. If we are in CFUN=4, it seems
that we have to wait after sending the CFUN=1 to goes online.
I have attached a full log with only CFUN=1 and no CFUN=4. I have replaced the CFUN=4 by
a CFUN=1.
You will see that CBS is supported, USSD also...
if this hardware can not deal with online/offline mode changes proper
then just remove the set_online modem driver callback and treat it like
a really dumb stupid device.
Only then you can go directly into CFUN=1 and stay there. Otherwise you
are violating online/offline semantics of oFono.
Regards
Marcel
11:46 p.m.
Hi,
> > Some other comments along the lines for this modem:
> >
> > ofonod[26439]: Aux: > AT+CSCB=?\r
> > ofonod[26439]: Aux: < \r\nERROR\r\n
> > ofonod[26439]: CSCB not supported
> >
> > Since CBS is not supported, do not even bother creating that atom.
>
> As I explained, all those errors are due to the CPIN=1. If we are in CFUN=4,
it seems that we have to wait after sending the CFUN=1 to goes online.
>
> I have attached a full log with only CFUN=1 and no CFUN=4. I have replaced
the CFUN=4 by a CFUN=1.
>
> You will see that CBS is supported, USSD also...
if this hardware can not deal with online/offline mode changes proper
then just remove the set_online modem driver callback and treat it like
a really dumb stupid device.
Only then you can go directly into CFUN=1 and stay there. Otherwise you
are violating online/offline semantics of oFono.
Ok, I will do this.
Thanks for your support,
Bertrand
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
1:24 a.m.
Hi,
> > > Some other comments along the lines for this modem:
> > >
> > > ofonod[26439]: Aux: > AT+CSCB=?\r
> > > ofonod[26439]: Aux: < \r\nERROR\r\n
> > > ofonod[26439]: CSCB not supported
> > >
> > > Since CBS is not supported, do not even bother creating that atom.
> >
> > As I explained, all those errors are due to the CPIN=1. If we are in
CFUN=4,
> it seems that we have to wait after sending the CFUN=1 to goes online.
> >
> > I have attached a full log with only CFUN=1 and no CFUN=4. I have replaced
> the CFUN=4 by a CFUN=1.
> >
> > You will see that CBS is supported, USSD also...
>
> if this hardware can not deal with online/offline mode changes proper
> then just remove the set_online modem driver callback and treat it like
> a really dumb stupid device.
>
> Only then you can go directly into CFUN=1 and stay there. Otherwise you
> are violating online/offline semantics of oFono.
Ok, I will do this.
Here is the result. I have attach the log, and everything looks fine.
Thanks again, I am preparing the patch.
Regards,
Bertrand
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
4070
days inactive
4070
days old
8 comments
3 participants
participants (3)
-
Aygon, Bertrand -
Bertrand Aygon
-
Marcel Holtmann