8:21 p.m.
Hi,
while reading mmsd sources I stumbled over missing length
checks in src/push.c:mms_push_notify(). I didn't re-read
the entire source to prove overall ;)
Best regards,
Jens
4:22 a.m.
Hi Jens,
while reading mmsd sources I stumbled over missing length
checks in src/push.c:mms_push_notify(). I didn't re-read
the entire source to prove overall ;)
please use git format-patch and git send-email to send us inline
patches. In case your email client doesn't support inline patches
nicely. Reviewing patches that are attached is super painful and in most
cases they get ignored then.
Regards
Marcel
7:30 p.m.
Am 27.02.2012 18:22, schrieb Marcel Holtmann:
Hi Jens,
Hi Marcel,
> while reading mmsd sources I stumbled over missing length
> checks in src/push.c:mms_push_notify(). I didn't re-read
> the entire source to prove overall ;)
please use git format-patch and git send-email to send us inline
patches. In case your email client doesn't support inline patches
nicely.
Well, inline patches aren't requested at
http://ofono.org/wiki/ofono-etiquette. You probably should do.
Reviewing patches that are attached is super painful and in most
cases they get ignored then.
Well, my mail client (Thunderbird) and most modern clients I
know are able to show attached files of text/x-patch (and
similar) type. OTOH I wonder why you want to review patches
in your mail client. Wouldn't it much better to use a
specialized too which highlights the changes like
$ gvim "+vert diffpatch <patchfile>" <originalfile>
$ emacs
or
$ xfdiff ?
Don't you have to save the patch files in such cases anyway?
Best regards,
Jens
1:38 p.m.
Hi Jens,
Well, my mail client (Thunderbird) and most modern clients I
know are able to show attached files of text/x-patch (and
similar) type. OTOH I wonder why you want to review patches
in your mail client. Wouldn't it much better to use a
It is not that we read patches in the mail client, but that is also
useful. The main use-case is to be able to easily comment on the patch
if changes are required. And for that we require patches to be sent inline.
specialized too which highlights the changes like
$ gvim "+vert diffpatch <patchfile>" <originalfile>
$ emacs
or
$ xfdiff ?
Don't you have to save the patch files in such cases anyway?
No, the typical workflow (at least for me) is to
- 'Save Email'
- vim email
- if looks okay, git am and compile test
Regards,
-Denis
3855
days inactive
3856
days old
3 comments
3 participants
participants (3)
-
Denis Kenzior -
Jens Rehsack -
Marcel Holtmann