Date: Thu, 12 Feb 2015 12:59:18 -0600 From: Denis Kenzior <denkenz(a)gmail.com&gt; To: ofono(a)ofono.org Subject: Re: [PATCH 1/2] sms: SMS-DELIVER TP-OA Alphanum decoding and encoding fix Message-ID: <54DCF806.5060609(a)gmail.com&gt; Content-Type: text/plain; charset=ISO-8859-1; format=flowed Hi Tommi, On 02/12/2015 09:09 AM, Tommi Kenakkala wrote: > Ofono ignores receved SMS if they have a long alphanum address with > extended ascii characters: > 1) sms_encode_address_field: TP-OA max length comparison before encoding > is incorrect because TP-OA's 11 octets are 7-bit coded and thus transport > twelve 8-bit chars. Change ofono to compare character count to character > limit instead of octet limit. How did you arrive at 11 octet figure? TP-OA is limited to 12 bytes. So 12 - TON - LEN = 10 bytes payload.