8:13 p.m.
Hello,
This patch series cleans up and fixes a number of small bits in the Phonet pipe code,
especially the experimental pipe
controller. Once this small bits are sorted out, I will try to fix the controller protocol
implementation proper so that we do not
need the compile-time (experimental) flag anymore.
Comments welcome,
include/net/phonet/pep.h | 22 ----
include/net/phonet/phonet.h | 1
net/phonet/af_phonet.c | 19 ++-
net/phonet/pep.c | 240 +++++++++++++++-----------------------------
net/phonet/socket.c | 14 +-
5 files changed, 106 insertions(+), 190 deletions(-)
--
Rémi Denis-Courmont
http://www.remlab.net/
6:20 a.m.
From: "Rémi Denis-Courmont" <remi.denis-courmont(a)nokia.com>
Date: Fri, 25 Feb 2011 11:13:41 +0200
This patch series cleans up and fixes a number of small bits in the
Phonet pipe code, especially the experimental pipe controller. Once
this small bits are sorted out, I will try to fix the controller
protocol implementation proper so that we do not need the
compile-time (experimental) flag anymore.
All applied thanks.
If you want to start using GIT to push phonet changes to me, frankly I
would welcome that :-)
6:23 a.m.
From: David Miller <davem(a)davemloft.net>
Date: Fri, 25 Feb 2011 11:20:55 -0800 (PST)
From: "Rémi Denis-Courmont"
<remi.denis-courmont(a)nokia.com>
Date: Fri, 25 Feb 2011 11:13:41 +0200
> This patch series cleans up and fixes a number of small bits in the
> Phonet pipe code, especially the experimental pipe controller. Once
> this small bits are sorted out, I will try to fix the controller
> protocol implementation proper so that we do not need the
> compile-time (experimental) flag anymore.
All applied thanks.
If you want to start using GIT to push phonet changes to me, frankly I
would welcome that :-)
BTW, I had to add the following patch to fix a build warning:
--------------------
phonet: Protect pipe_do_remove() with appropriate ifdefs.
It is only used when CONFIG_PHONET_PIPECTRLR is not set.
Signed-off-by: David S. Miller <davem(a)davemloft.net>
---
net/phonet/pep.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/phonet/pep.c b/net/phonet/pep.c
index b8c31fc..875e86c 100644
--- a/net/phonet/pep.c
+++ b/net/phonet/pep.c
@@ -849,6 +849,7 @@ drop:
return err;
}
+#ifndef CONFIG_PHONET_PIPECTRLR
static int pipe_do_remove(struct sock *sk)
{
struct pep_sock *pn = pep_sk(sk);
@@ -870,6 +871,7 @@ static int pipe_do_remove(struct sock *sk)
return pn_skb_send(sk, skb, NULL);
}
+#endif
/* associated socket ceases to exist */
static void pep_sock_close(struct sock *sk, long timeout)
--
1.7.4.1
8:15 p.m.
Le vendredi 25 février 2011 21:24:06 David Miller, vous avez écrit :
> From: "Rémi Denis-Courmont"
<remi.denis-courmont(a)nokia.com>
> Date: Fri, 25 Feb 2011 11:13:41 +0200
>
>> This patch series cleans up and fixes a number of small bits in the
>> Phonet pipe code, especially the experimental pipe controller. Once
>> this small bits are sorted out, I will try to fix the controller
>> protocol implementation proper so that we do not need the
>> compile-time (experimental) flag anymore.
>
> All applied thanks.
>
> If you want to start using GIT to push phonet changes to me, frankly I
> would welcome that :-)
No problem in principles. I need to figure out where to put linux-phonet.git
though.
BTW, I had to add the following patch to fix a build warning:
Hmm, right. I am planning to kill this config option and reunify the cough
cough chal-len-ged *ahem* ST-Ericsson code with the Nokia code... So I confess
did not bother to eliminate that ST-Ericsson-only mode warning.
--
Rémi Denis-Courmont
http://www.remlab.info/
http://fi.linkedin.com/in/remidenis
4222
days inactive
4223
days old
3 comments
3 participants
participants (3)
-
David Miller -
Rémi Denis-Courmont -
Rémi Denis-Courmont