12:10 a.m.
cb_data_new() uses g_new0(), hence there's no need to check the return
value being NULL.
---
plugins/huawei.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/plugins/huawei.c b/plugins/huawei.c
index 6f05677..afa804d 100644
--- a/plugins/huawei.c
+++ b/plugins/huawei.c
@@ -600,13 +600,9 @@ static void huawei_set_online(struct ofono_modem *modem, ofono_bool_t
online,
DBG("modem %p %s", modem, online ? "online" : "offline");
- if (cbd == NULL)
- goto error;
-
if (g_at_chat_send(chat, command, NULL, set_online_cb, cbd, g_free))
return;
-error:
g_free(cbd);
CALLBACK_WITH_FAILURE(cb, cbd->data);
--
1.7.4.1
12:10 a.m.
New subject: [PATCH 2/2] mbmmodem: do not check for NULL pointer
cb_data_new() uses g_new0(), hence there's no need to check the return
value being NULL.
---
drivers/mbmmodem/location-reporting.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/mbmmodem/location-reporting.c
b/drivers/mbmmodem/location-reporting.c
index b76a5c2..1080e62 100644
--- a/drivers/mbmmodem/location-reporting.c
+++ b/drivers/mbmmodem/location-reporting.c
@@ -166,16 +166,12 @@ static void mbm_location_reporting_enable(struct
ofono_location_reporting *lr,
DBG("lr=%p", lr);
- if (cbd == NULL)
- goto out;
-
cbd->user = lr;
if (g_at_chat_send(gd->chat, "AT*E2GPSCTL=1,5,1", none_prefix,
mbm_e2gpsctl_enable_cb, cbd, g_free) > 0)
return;
-out:
CALLBACK_WITH_FAILURE(cb, -1, data);
g_free(cbd);
}
--
1.7.4.1
12:15 a.m.
New subject: [PATCH 2/2] mbmmodem: do not check for NULL pointer
Hi Lucas,
cb_data_new() uses g_new0(), hence there's no need to check the
return
value being NULL.
---
drivers/mbmmodem/location-reporting.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
patch has been applied. Thanks.
Regards
Marcel
4216
days inactive
4216
days old
3 comments
2 participants
participants (2)
-
Lucas De Marchi -
Marcel Holtmann