I regenerated the patch again. Thank denis for good advice. Best Regards, Minjun -----Original Message----- From: Kenzior, Denis Sent: 2009年6月3日 6:38 To: ofono(a)ofono.org Cc: Li, Minjun Subject: Re: add a common exit function for interfaces when manager_free and manager_destroy function is called Hi Minjun, On Tuesday 02 June 2009 02:02:29 Li, Minjun wrote: In interface_exit: Please remove if (at) block, its pointless. Please get rid of all mode changes, only submit changes to files that are relevant to the fix. Get a proper commit message. E.g. put the description in the email into the commit message. Regards, -Denis