6:06 p.m.
Heyho,
while working with phonesim's dbus interface I discovered it's not using for each
reported
error the same error domain. The attached patch fixes this.
regards,
Simon
Simon Busch (1):
control: use correct dbus error domain
src/control.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
1.7.9.5
6:06 p.m.
New subject: [PATCH] control: use correct dbus error domain
Before it was org.ofono.phonesimError but should be consistent with the other error
reports and should use org.ofono.phonesim.Error.
Signed-off-by: Simon Busch <morphis(a)gravedo.de>
---
src/control.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/control.cpp b/src/control.cpp
index 9085acd..3f1dd45 100644
--- a/src/control.cpp
+++ b/src/control.cpp
@@ -711,7 +711,7 @@ QString Script::Run(const QString &name, const QDBusMessage
&msg)
QScriptValue qsScript = engine.evaluate(contents);
if (qsScript.isError()) {
QString info = fileName + ", line " +
qsScript.property("lineNumber").toString() + ", " +
qsScript.toString();
- QDBusMessage reply = msg.createErrorReply(SERVICE
"Error.ScriptExecError", info);
+ QDBusMessage reply = msg.createErrorReply(SERVICE
".Error.ScriptExecError", info);
QDBusConnection::sessionBus().send(reply);
return QString();
}
--
1.7.9.5
2:17 a.m.
New subject: [PATCH] control: use correct dbus error domain
Hi Simon,
On 07/12/2012 03:06 AM, Simon Busch wrote:
Before it was org.ofono.phonesimError but should be consistent with
the other error
reports and should use org.ofono.phonesim.Error.
Signed-off-by: Simon Busch<morphis(a)gravedo.de>
Please note that we do not use Signed-off-by
---
src/control.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Patch has been applied, thanks.
Regards,
-Denis
2:33 a.m.
New subject: [PATCH] control: use correct dbus error domain
Am 12.07.2012 18:17, schrieb Denis Kenzior:
Hi Simon,
On 07/12/2012 03:06 AM, Simon Busch wrote:
> Before it was org.ofono.phonesimError but should be consistent with
> the other error
> reports and should use org.ofono.phonesim.Error.
>
> Signed-off-by: Simon Busch<morphis(a)gravedo.de>
Please note that we do not use Signed-off-by
Ok, will consider this the next time.
> ---
> src/control.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Patch has been applied, thanks.
Thanks a lot.
regards,
Simon
--
Simon Busch - http://mm.gravedo.de/blog/
3720
days inactive
3720
days old
3 comments
2 participants
participants (2)
-
Denis Kenzior -
Simon Busch