Fix typo in location-reporting-api.txt. AFAICT, at_cmt_notify() calls ofono_error even in case stuff is okay. Fix that. Move debug print to more useful place in setup_gobi(). Explain "delivery report" parameter in send-sms. diff --git a/doc/location-reporting-api.txt b/doc/location-reporting-api.txt index 21e346d4..ff0a35dc 100644 --- a/doc/location-reporting-api.txt +++ b/doc/location-reporting-api.txt @@ -13,7 +13,7 @@ Methods dict GetProperties() filedescriptor Request() Asks to turn ON the NMEA stream and supplies the - gps device file descriptor. The external cliend should + gps device file descriptor. The external client should use the file descriptor to receive the NMEA data. Possible Errors: [service].Error.InProgress diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c index 68b89862..217971e7 100644 --- a/drivers/atmodem/sms.c +++ b/drivers/atmodem/sms.c @@ -440,6 +436,8 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data) if (data->vendor != OFONO_VENDOR_SIMCOM) at_ack_delivery(sms); + return; + err: ofono_error("Unable to parse CMT notification"); } diff --git a/plugins/udevng.c b/plugins/udevng.c index ff5d41af..a4b18488 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -233,10 +233,11 @@ static gboolean setup_gobi(struct modem_info *modem) } } + DBG("qmi=%s net=%s mdm=%s gps=%s diag=%s", qmi, net, mdm, gps, diag); + if (qmi == NULL || mdm == NULL || net == NULL) return FALSE; - DBG("qmi=%s net=%s mdm=%s gps=%s diag=%s", qmi, net, mdm, gps, diag); ofono_modem_set_string(modem->modem, "Device", qmi); ofono_modem_set_string(modem->modem, "Modem", mdm); diff --git a/test/send-sms b/test/send-sms index 98808aaf..cabe0652 100755 --- a/test/send-sms +++ b/test/send-sms @@ -6,6 +6,7 @@ import dbus if len(sys.argv) < 4: print("Usage: %s [modem] <to> <message> <delivery report>" %\ (sys.argv[0])) + print(" where delivery report is 0|1") sys.exit(1) bus = dbus.SystemBus() -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html