[PATCH 1/1] SIM detection: Fixing the logical error in using the number of slot and number of application
3:07 p.m.
From d1ec66c643f005d558c403a68c7df04b0819aa79 Mon Sep 17 00:00:00 2001
From: "Eswaran Vinothkumar (BEG-PT/PJ-IOT1)"
<Vinothkumar.Eswaran(a)de.bosch.com>
Date: Mon, 12 Mar 2018 14:46:28 +0100
Subject: [PATCH] sim detection: Fix to take the right slot and application
number
---
drivers/qmimodem/sim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/qmimodem/sim.c b/drivers/qmimodem/sim.c
index 71c7e04..99c6d68 100644
--- a/drivers/qmimodem/sim.c
+++ b/drivers/qmimodem/sim.c
@@ -557,7 +557,7 @@ static enum get_card_status_result handle_get_card_status_result(
index = GUINT16_FROM_LE(status->index_gw_pri);
- if ((index & 0xff) == i && (index >>
8) == n) {
+ if ((index & 0xff) == n && (index >>
8) == i) {
if (get_card_status(slot, info1, info2,
sim_stat))
res =
GET_CARD_STATUS_RESULT_TEMP_ERROR;
--
2.7.4
Mit freundlichen Grüßen / Best regards
Vinothkumar Eswaran
BEG-PT/PJ-IOT-EL
3:43 p.m.
Hi,
On 03/12/2018 09:07 AM, Eswaran Vinothkumar (BEG/PJ-IOT-EL) wrote:
From d1ec66c643f005d558c403a68c7df04b0819aa79 Mon Sep 17 00:00:00
2001
From: "Eswaran Vinothkumar (BEG-PT/PJ-IOT1)"
<Vinothkumar.Eswaran(a)de.bosch.com>
Date: Mon, 12 Mar 2018 14:46:28 +0100
Subject: [PATCH] sim detection: Fix to take the right slot and application
number
---
drivers/qmimodem/sim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I can't apply this patch..
Could you please use git send-email and resubmit?
Regards,
-Denis
10:31 a.m.
Hi,
I have a Japanese SIM card which is not detected because of this issue.
So I would like to see this patch included.
Here is a version of the patch using git send-email.
I don't know how to say that Eswaran Vinothkumar is the author.
I hope you can fix that.
Best Regards,
Christophe
Christophe Ronco (1):
qmi: use right slot and application during SIM detection
drivers/qmimodem/sim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.7.4
10:31 a.m.
New subject: [PATCH 1/1] qmi: use right slot and application during SIM detection
Use right slot and application to get card status, PIN status and PIN
retries. Without this patch, SIMs where selected application and slot
numbers are different are not detected.
---
drivers/qmimodem/sim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/qmimodem/sim.c b/drivers/qmimodem/sim.c
index 9aa943b..1ac5068 100644
--- a/drivers/qmimodem/sim.c
+++ b/drivers/qmimodem/sim.c
@@ -564,7 +564,7 @@ static enum get_card_status_result handle_get_card_status_result(
index = GUINT16_FROM_LE(status->index_gw_pri);
- if ((index & 0xff) == i && (index >> 8) == n) {
+ if ((index & 0xff) == n && (index >> 8) == i) {
if (get_card_status(slot, info1, info2,
sim_stat))
res = GET_CARD_STATUS_RESULT_TEMP_ERROR;
--
2.7.4
5:25 p.m.
New subject: [PATCH 1/1] qmi: use right slot and application during SIM detection
Hi Christophe,
On 04/19/2018 03:31 AM, Christophe Ronco wrote:
Use right slot and application to get card status, PIN status and
PIN
retries. Without this patch, SIMs where selected application and slot
numbers are different are not detected.
---
drivers/qmimodem/sim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Regards,
-Denis
1492
days inactive
1530
days old
4 comments
3 participants
participants (3)
-
Christophe Ronco -
Denis Kenzior -
Eswaran Vinothkumar (BEG/PJ-IOT-EL)