Hi Bertrand,
plugins/speedupcdma.c | 99
++++++++++++++++++++++++++++++++++++-------------
1 files changed, 73 insertions(+), 26 deletions(-)
diff --git a/plugins/speedupcdma.c b/plugins/speedupcdma.c
index d11afb7..8cb4dae 100644
--- a/plugins/speedupcdma.c
+++ b/plugins/speedupcdma.c
@@ -40,7 +40,8 @@
static const char *none_prefix[] = { NULL };
struct speedupcdma_data {
- GAtChat *chat;
+ GAtChat *modem;
+ GAtChat *aux;
};
static void speedupcdma_debug(const char *str, void *data)
@@ -84,8 +85,11 @@ static void cfun_enable(gboolean ok, GAtResult *result, gpointer
user_data)
DBG("");
if (!ok) {
- g_at_chat_unref(data->chat);
- data->chat = NULL;
+ g_at_chat_unref(data->modem);
+ data->modem = NULL;
+
+ g_at_chat_unref(data->aux);
+ data->aux = NULL;
ofono_modem_set_powered(modem, FALSE);
return;
@@ -94,39 +98,70 @@ static void cfun_enable(gboolean ok, GAtResult *result, gpointer
user_data)
ofono_modem_set_powered(modem, TRUE);
}
-static int speedupcdma_enable(struct ofono_modem *modem)
+static GAtChat *create_port(const char *device)
{
- struct speedupcdma_data *data = ofono_modem_get_data(modem);
GAtSyntax *syntax;
GIOChannel *channel;
- const char *modem_path;
-
- modem_path = ofono_modem_get_string(modem, "Modem");
- if (modem_path == NULL)
- return -EINVAL;
-
- DBG("path is: %s", modem_path);
+ GAtChat *chat;
- channel = g_at_tty_open(modem_path, NULL);
+ channel = g_at_tty_open(device, NULL);
if (channel == NULL)
- return -EIO;
+ return NULL;
syntax = g_at_syntax_new_gsm_permissive();
- data->chat = g_at_chat_new(channel, syntax);
+ chat = g_at_chat_new(channel, syntax);
g_at_syntax_unref(syntax);
-
g_io_channel_unref(channel);
- if (data->chat == NULL)
- return -ENOMEM;
+ if (chat == NULL)
+ return NULL;
+
+ return chat;
+}
+
+static GAtChat *open_device(struct ofono_modem *modem,
+ const char *key, char *debug)
+{
+ const char *device;
+ GAtChat *chat;
+
+ device = ofono_modem_get_string(modem, key);
+ if (device == NULL)
+ return NULL;
+
+ DBG("%s %s", key, device);
+
+ chat = create_port(device);
+ if (chat == NULL)
+ return NULL;
if (getenv("OFONO_AT_DEBUG"))
- g_at_chat_set_debug(data->chat, speedupcdma_debug, "Modem: ");
+ g_at_chat_set_debug(chat, speedupcdma_debug, debug);
+
+ return chat;
+}
+
I think that you can also fold create_port into open_device nicely.
Seems like we heavily overcomplicated other code. Need to fix the other
code as well then ;)
+static int speedupcdma_enable(struct ofono_modem *modem)
+{
+ struct speedupcdma_data *data = ofono_modem_get_data(modem);
+
+ DBG("");
- g_at_chat_send(data->chat, "ATE0 +CMEE=1", none_prefix,
+ data->modem = open_device(modem, "Modem", "Modem: ");
+ if (data->modem == NULL)
+ return -EINVAL;
+
+ data->aux = open_device(modem, "Aux", "Aux: ");
+ if (data->aux == NULL) {
+ g_at_chat_unref(data->modem);
+ data->modem = NULL;
+ return -EIO;
+ }
+
+ g_at_chat_send(data->aux, "ATE0 +CMEE=1", none_prefix,
NULL, NULL, NULL);
We should send the ATE0 on both channels. And while you are at it, make
it ATE0 &C0 +CMEE1 actually.
I am changing all other drivers to include &C0 behavior.
- g_at_chat_send(data->chat, "AT+CFUN=1", none_prefix,
+ g_at_chat_send(data->aux, "AT+CFUN=1", none_prefix,
cfun_enable, modem, NULL);
return -EINPROGRESS;
@@ -139,8 +174,8 @@ static void cfun_disable(gboolean ok, GAtResult *result, gpointer
user_data)
DBG("");
- g_at_chat_unref(data->chat);
- data->chat = NULL;
+ g_at_chat_unref(data->aux);
+ data->aux = NULL;
if (ok)
ofono_modem_set_powered(modem, FALSE);
@@ -152,7 +187,19 @@ static int speedupcdma_disable(struct ofono_modem *modem)
DBG("%p", modem);
- g_at_chat_send(data->chat, "AT+CFUN=0", none_prefix,
+ if (data->modem) {
+ g_at_chat_cancel_all(data->modem);
+ g_at_chat_unregister_all(data->modem);
Extra empty line here please.
+ g_at_chat_unref(data->modem);
+ data->modem = NULL;
+ }
No need to check for data->modem here. _enable would fail if you can not
set it up. So you always have a valid data->modem.
Some of our drivers that you used as example are doing this wrong and I
am going to fix them actually.
+
+ if (data->aux == NULL)
+ return 0;
No need for this check either. data->aux will be valid.
+
+ g_at_chat_cancel_all(data->aux);
+ g_at_chat_unregister_all(data->aux);
Extra empty line here please.
+ g_at_chat_send(data->aux, "AT+CFUN=0", none_prefix,
cfun_disable, modem, NULL);
return -EINPROGRESS;
@@ -164,7 +211,7 @@ static void speedupcdma_pre_sim(struct ofono_modem *modem)
DBG("%p", modem);
- ofono_devinfo_create(modem, 0, "cdmamodem", data->chat);
+ ofono_devinfo_create(modem, 0, "cdmamodem", data->aux);
}
static void speedupcdma_post_sim(struct ofono_modem *modem)
@@ -178,7 +225,7 @@ static void speedupcdma_post_online(struct ofono_modem *modem)
DBG("%p", modem);
- ofono_cdma_connman_create(modem, 0, "cdmamodem", data->chat);
+ ofono_cdma_connman_create(modem, 1, "cdmamodem", data->modem);
Please leave vendor as 0. That is a different patch.
}
static struct ofono_modem_driver speedupcdma_driver = {
Regards
Marcel