On 12/22/2015 01:10 AM, Denis Kenzior wrote:
On 12/21/2015 04:03 AM, John Ernberg wrote:
> From: John Ernberg <john.ernberg(a)actia.se>
> When issuing a Scan() in poor reception while attached to an operator
> fully possible to get no results, which causes the attached operator
> to be
> cleaned up. In certain scenarios this would cause a use-after-free.
> Make sure to clean up all the references to the operator when it's
> src/network.c | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/src/network.c b/src/network.c
> index 1dddcac..5329c28 100644
> --- a/src/network.c
> +++ b/src/network.c
> @@ -257,6 +257,9 @@ static void network_operator_destroy(gpointer
> struct network_operator_data *op = user_data;
> + if (op->netreg->current_operator == op)
> + op->netreg->current_operator = NULL;
I'm not sure this is the right fix. This will result in subsequent
API calls to return inconsistent information related to the network
operator. For example, NetworkRegistration.Name,
NetworkRegistration.MobileCountryCode will be omitted.
Can we make sure that the current operator is not destroyed /
unregistered in this particular situation?
It may be possible but I could not
figure out a way to do that. So I did
it like this to at least prevent the resulting SIGSEGV.
Best regards // John Ernberg