12:19 a.m.
This is the default asked by HSP and HFP specifications, which
is the opposite of what v250 is asking.
Frédéric Dalleau (2):
gatchat: Add function to enable/disable echo
emulator: Disable echo for hfp emulators
gatchat/gatserver.c | 10 ++++++++++
gatchat/gatserver.h | 1 +
src/emulator.c | 2 ++
3 files changed, 13 insertions(+), 0 deletions(-)
12:19 a.m.
New subject: [PATCH 1/2] gatchat: Add function to enable/disable echo
---
gatchat/gatserver.c | 10 ++++++++++
gatchat/gatserver.h | 1 +
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c
index b092a68..d9b1592 100644
--- a/gatchat/gatserver.c
+++ b/gatchat/gatserver.c
@@ -1235,6 +1235,16 @@ gboolean g_at_server_shutdown(GAtServer *server)
return TRUE;
}
+gboolean g_at_server_set_echo(GAtServer *server, gboolean echo)
+{
+ if (server == NULL)
+ return FALSE;
+
+ server->v250.echo = echo;
+
+ return TRUE;
+}
+
gboolean g_at_server_set_disconnect_function(GAtServer *server,
GAtDisconnectFunc disconnect,
gpointer user_data)
diff --git a/gatchat/gatserver.h b/gatchat/gatserver.h
index a42c8b5..bb0ae84 100644
--- a/gatchat/gatserver.h
+++ b/gatchat/gatserver.h
@@ -80,6 +80,7 @@ void g_at_server_unref(GAtServer *server);
gboolean g_at_server_shutdown(GAtServer *server);
+gboolean g_at_server_set_echo(GAtServer *server, gboolean echo);
gboolean g_at_server_set_disconnect_function(GAtServer *server,
GAtDisconnectFunc disconnect,
gpointer user_data);
--
1.7.1
12:19 a.m.
New subject: [PATCH 2/2] emulator: Disable echo for hfp emulators
---
src/emulator.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/emulator.c b/src/emulator.c
index dcfd296..7007882 100644
--- a/src/emulator.c
+++ b/src/emulator.c
@@ -203,6 +203,8 @@ void ofono_emulator_register(struct ofono_emulator *em, int fd)
if (em->type == OFONO_EMULATOR_TYPE_DUN)
g_at_server_register(em->server, "D", dial_cb, em, NULL);
+ else if (em->type == OFONO_EMULATOR_TYPE_HFP)
+ g_at_server_set_echo(em->server, FALSE);
}
static void emulator_remove(struct ofono_atom *atom)
--
1.7.1
2:31 a.m.
Hi Frédéric,
On 02/23/2011 07:19 AM, Frédéric Dalleau wrote:
This is the default asked by HSP and HFP specifications, which
is the opposite of what v250 is asking.
Frédéric Dalleau (2):
gatchat: Add function to enable/disable echo
emulator: Disable echo for hfp emulators
gatchat/gatserver.c | 10 ++++++++++
gatchat/gatserver.h | 1 +
src/emulator.c | 2 ++
3 files changed, 13 insertions(+), 0 deletions(-)
Both patches have been applied, thanks.
Regards,
-Denis
4225
days inactive
4225
days old
3 comments
2 participants
participants (2)
-
Denis Kenzior -
Frédéric Dalleau