1:14 p.m.
Hi,
Here's a patch to fix network registration with older ISI modems.
Verified with N95.
Claudio, could you give this a spin and let me know if this fixes
the problem for your 6760?
Br,
MikaL
[PATCH 1/1] isimodem: fix network registration for older modems
drivers/isimodem/network-registration.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
1:14 p.m.
New subject: [PATCH 1/1] isimodem: fix network registration for older modems
---
drivers/isimodem/network-registration.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/isimodem/network-registration.c
b/drivers/isimodem/network-registration.c
index a30fc8c..8bf2423 100644
--- a/drivers/isimodem/network-registration.c
+++ b/drivers/isimodem/network-registration.c
@@ -78,6 +78,7 @@ struct netreg_data {
struct reg_info reg;
struct gsm_info gsm;
struct rat_info rat;
+ GIsiVersion version;
char nitz_name[OFONO_MAX_OPERATOR_NAME_LENGTH + 1];
};
@@ -338,7 +339,8 @@ static void rat_resp_cb(const GIsiMessage *msg, void *data)
goto error;
}
- if (g_isi_client_resource(nd->client) == PN_MODEM_NETWORK)
+ if (g_isi_client_resource(nd->client) == PN_MODEM_NETWORK ||
+ nd->version.major < 14)
req[0] = NET_MODEM_REG_STATUS_GET_REQ;
if (g_isi_client_send(nd->client, req, sizeof(req),
@@ -649,7 +651,8 @@ static void isi_list_operators(struct ofono_netreg *netreg,
if (cbd == NULL || nd == NULL)
goto error;
- if (g_isi_client_resource(nd->client) == PN_MODEM_NETWORK)
+ if (g_isi_client_resource(nd->client) == PN_MODEM_NETWORK ||
+ nd->version.major < 14)
msg[0] = NET_MODEM_AVAILABLE_GET_REQ;
if (g_isi_client_send_with_timeout(nd->client, msg, sizeof(msg),
@@ -938,6 +941,9 @@ static void reachable_cb(const GIsiMessage *msg, void *data)
if (nd == NULL)
return;
+ nd->version.major = g_isi_msg_version_major(msg);
+ nd->version.minor = g_isi_msg_version_minor(msg);
+
g_isi_client_ind_subscribe(nd->client, NET_RSSI_IND, rssi_ind_cb,
netreg);
g_isi_client_ind_subscribe(nd->client, NET_NITZ_NAME_IND, name_ind_cb,
--
1.7.1
1:45 p.m.
New subject: [PATCH 1/1] isimodem: fix network registration for older modems
Hi Mika,
2011/3/24 Mika Liljeberg <mika.liljeberg(a)nokia.com>:
---
drivers/isimodem/network-registration.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
Patch has been pushed. Thanks.
Cheers,
Aki
11:21 a.m.
On Thu, 2011-03-24 at 14:14 +0200, Mika Liljeberg wrote:
Hi,
Here's a patch to fix network registration with older ISI modems.
Verified with N95.
Claudio, could you give this a spin and let me know if this fixes
the problem for your 6760?
Hi Mika,
Thanks very much for the patch :
I have tested the path of isi modem on nokia n95 and nokia 6760,
and I report the result of my test
1) Using nokia N95 and ofono
* I have attached the phone to my computer
* I have used the ./online-modem
* I have set apn/username/password and activate the context
It works (log onlineUsingOfonoTest file attached to mail)
2) Using nokia N95 and ofono/connma
* I have attached the phone to my computer
* Start connman and I have checked it set OnLine the modem correctly
* I have set apn/username/password and activate the context
* Using connect of connman, but i receive the message
org.ofono.Error.NotAttached GPRS is not attached
I reports the log onlineUsingConnmanTest, can be a problem of connman ?
1) Using nokia 6760 and ofono
* I have attached the phone to my computer
* I have used the ./online-modem
* I have set apn/username/password and activate the context
It not works, (log in nokia6760 file attached to mail)
Any suggestion ?
is it possible to know the list of supported mobile phone as 3g modem ?
regs
Br,
MikaL
[PATCH 1/1] isimodem: fix network registration for older modems
drivers/isimodem/network-registration.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
9:07 a.m.
Hi Claudio,
I have tested the path of isi modem on nokia n95 and nokia 6760,
and I report the result of my test
1) Using nokia N95 and ofono
* I have attached the phone to my computer
* I have used the ./online-modem
* I have set apn/username/password and activate the context
It works (log onlineUsingOfonoTest file attached to mail)
Cool.
2) Using nokia N95 and ofono/connma
* I have attached the phone to my computer
* Start connman and I have checked it set OnLine the modem correctly
* I have set apn/username/password and activate the context
* Using connect of connman, but i receive the message
org.ofono.Error.NotAttached GPRS is not attached
I reports the log onlineUsingConnmanTest, can be a problem of
connman ?
I was able to reproduce this with N95 without using connman. There seems to be a conflict
with the way atom watches are registered and the way isiusb creates and probes two
variations of the network registration driver in parallel. The problem is timing
dependent, which is probably why we haven't seen it here before.
1) Using nokia 6760 and ofono
* I have attached the phone to my computer
* I have used the ./online-modem
* I have set apn/username/password and activate the context
It not works, (log in nokia6760 file attached to mail)
Any suggestion ?
I believe the same problem also happens with 6760 and could potentially happen with any
ISI modem. Now that I know what it is, I'll try to provide patches.
is it possible to know the list of supported mobile phone as
3g modem ?
We don't have a list of supported phones as such as we're not systematically
tesing oFono against old Nokia phones. The isiusb plugin is primarily a development aid,
allowing us to test isimodem drivers on a PC instead of on-target. There are some
limitations in using the isimodem driver over USB this way. All functionality may not be
available with all phones. Mostly it works fine, though.
Regards,
MikaL
9:52 a.m.
Hi Mika,
On Tue, 2011-03-29 at 07:07 +0000, Mika.Liljeberg(a)nokia.com wrote:
Hi Claudio,
> I have tested the path of isi modem on nokia n95 and nokia 6760,
> and I report the result of my test
>
> 1) Using nokia N95 and ofono
> * I have attached the phone to my computer
> * I have used the ./online-modem
> * I have set apn/username/password and activate the context
>
> It works (log onlineUsingOfonoTest file attached to mail)
Cool.
> 2) Using nokia N95 and ofono/connma
> * I have attached the phone to my computer
> * Start connman and I have checked it set OnLine the modem correctly
> * I have set apn/username/password and activate the context
> * Using connect of connman, but i receive the message
>
> org.ofono.Error.NotAttached GPRS is not attached
>
> I reports the log onlineUsingConnmanTest, can be a problem of
> connman ?
I was able to reproduce this with N95 without using connman. There seems to be a conflict
with the way atom watches are registered and the way isiusb creates and probes two
variations of the network registration driver in parallel. The problem is timing
dependent, which is probably why we haven't seen it here before.
> 1) Using nokia 6760 and ofono
> * I have attached the phone to my computer
> * I have used the ./online-modem
> * I have set apn/username/password and activate the context
>
> It not works, (log in nokia6760 file attached to mail)
>
> Any suggestion ?
I believe the same problem also happens with 6760 and could potentially happen with any
ISI modem. Now that I know what it is, I'll try to provide patches.
Thank you so much for your support and help, please let us know once you
have the patch.
> is it possible to know the list of supported mobile phone as
> 3g modem ?
We don't have a list of supported phones as such as we're not systematically
tesing oFono against old Nokia phones. The isiusb plugin is primarily a development aid,
allowing us to test isimodem drivers on a PC instead of on-target. There are some
limitations in using the isimodem driver over USB this way. All functionality may not be
available with all phones. Mostly it works fine, though.
I see.
Since each phone can potentially use a different way to talk to the pc
(Android: rndis, Nokia: AT commands / PPP interface over USB if I
understand it correctly), we are trying to understand which of these
methods (hence which phone family) is preferable to be used/supported
with connman / oFono.
Do you have any suggestion for us?
Regards,
MikaL
regs Claudio
11:29 a.m.
Hi Claudio,
Thank you so much for your support and help, please let us
know once you
have the patch.
I posted a few patches yesterday, which should improve things.
> > is it possible to know the list of supported mobile phone
as
> > 3g modem ?
>
> We don't have a list of supported phones as such as we're
not systematically tesing oFono against old Nokia phones. The
isiusb plugin is primarily a development aid, allowing us to
test isimodem drivers on a PC instead of on-target. There are
some limitations in using the isimodem driver over USB this
way. All functionality may not be available with all phones.
Mostly it works fine, though.
I see.
Since each phone can potentially use a different way to talk to the pc
(Android: rndis, Nokia: AT commands / PPP interface over USB if I
understand it correctly), we are trying to understand which of these
methods (hence which phone family) is preferable to be used/supported
with connman / oFono.
Do you have any suggestion for us?
My advice is to use whatever works for you. Currently, oFono recognizes Nokia phones only
via the isiusb plugin, so that is pretty much the only option. However, most Nokia phones
also support AT commands over USB ACM and should be relatively easy to get working with
oFono, if you're willing to write a new plugin or modify the current nokia plugin for
Nokia USB modems to include support for Nokia phones. Patches are welcome.
Br,
MikaL
8:57 a.m.
Hi mika,
Il 30/03/2011 11.29, Mika.Liljeberg(a)nokia.com ha scritto:
Hi Claudio,
I posted a few patches yesterday, which should improve things.
Great, thank you very much for patch. It's works fine now.
My advice is to use whatever works for you. Currently, oFono
recognizes Nokia phones only via the isiusb plugin, so that is pretty much the only
option. However, most Nokia phones also support AT commands over USB ACM and should be
relatively easy to get working with oFono, if you're willing to write a new plugin or
modify the current nokia plugin for Nokia USB modems to include support for Nokia phones.
Patches are welcome.
Thanks for the update!
regs
Claudio
3891
days inactive
3902
days old
7 comments
5 participants
participants (5)
-
Aki Niemi -
claudio Degioanni -
Claudio Degioanni
-
Mika Liljeberg -
Mika.Liljeberg＠nokia.com