9:13 p.m.
We should remove all atoms when we disable the modem. In function
set_powered, we remove all atoms if modem is powered down by dbus
call.
---
src/modem.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/src/modem.c b/src/modem.c
index 3a6a163..4b4a9ed 100644
--- a/src/modem.c
+++ b/src/modem.c
@@ -582,6 +582,9 @@ void ofono_modem_set_powered(struct ofono_modem *modem, ofono_bool_t
powered)
if (powered) {
if (modem->driver->pre_sim)
modem->driver->pre_sim(modem);
+ } else {
+ remove_all_atoms(modem);
+ modem->call_ids = 0;
}
}
--
1.6.5.2
9:13 p.m.
New subject: [PATCH 2/2] Fix update hfp_hangup to release active call
In HFP, AT+CHUP is intended to release the current active call.
---
drivers/hfpmodem/voicecall.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hfpmodem/voicecall.c b/drivers/hfpmodem/voicecall.c
index 6693280..17811d6 100644
--- a/drivers/hfpmodem/voicecall.c
+++ b/drivers/hfpmodem/voicecall.c
@@ -393,8 +393,8 @@ static void hfp_answer(struct ofono_voicecall *vc,
static void hfp_hangup(struct ofono_voicecall *vc,
ofono_voicecall_cb_t cb, void *data)
{
- /* Hangup all calls */
- hfp_template("AT+CHUP", vc, generic_cb, 0x3f, cb, data);
+ /* Hangup current active call */
+ hfp_template("AT+CHUP", vc, generic_cb, 0x1, cb, data);
}
static void hfp_hold_all_active(struct ofono_voicecall *vc,
--
1.6.5.2
12:52 a.m.
Hi,
Zhang, Zhenhua wrote:
We should remove all atoms when we disable the modem. In
function set_powered, we remove all atoms if modem is powered down by
dbus call. ---
src/modem.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
Let me explain more about this fix. In atmodem world, we use dbus call to
power on/off modem and then it calls set_powered() to remove all atoms.
However, in hfpmodem, the plugin may receive signal from BlueZ that remote
has closed the service level connection with us. So we must power off the modem
through ofono_modem_set_powered(modem, FALSE).
I also tried phonesim and don't find problem. Let me know if any questions or
issues. Thanks.
Regards,
Zhenhua
4667
days inactive
4667
days old
4 comments
3 participants
participants (3)
-
Denis Kenzior -
Zhang, Zhenhua -
Zhenhua Zhang