3:36 a.m.
Hi,
If sending of SMS fails, then oFono core will try to resend it after
n * 5 seconds(n = retry count). Due to this, conformance test case
27.22.8 sequence 1.4 fails(refer 31.124 spec). Plan is to limit the
failue codes for which the retry will be done. This patch allows the
retry if the failure is only due to network timeout. For all the other
failure cases, retry is not done.
Regards,
Jeevaka
Jeevaka Badrappan (1):
sms: limit the sms sending retry
src/sms.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
3:36 a.m.
New subject: [PATCH 1/1] sms: limit the sms sending retry
---
src/sms.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/sms.c b/src/sms.c
index 01f54dd..c4f8b54 100644
--- a/src/sms.c
+++ b/src/sms.c
@@ -47,6 +47,7 @@
#define SETTINGS_GROUP "Settings"
#define TXQ_MAX_RETRIES 4
+#define NETWORK_TIMEOUT 332
static gboolean tx_next(gpointer user_data);
@@ -630,6 +631,10 @@ static void tx_finished(const struct ofono_error *error, int mr, void
*data)
if (sms->registered == FALSE)
return;
+ /* Retry done only for Network Timeout failure */
+ if (error->error != NETWORK_TIMEOUT)
+ goto next_q;
+
if (!(entry->flags & OFONO_SMS_SUBMIT_FLAG_RETRY))
goto next_q;
--
1.7.0.4
4:13 a.m.
New subject: [PATCH 1/1] sms: limit the sms sending retry
Hi Jeevaka,
On 03/17/2011 11:36 AM, Jeevaka Badrappan wrote:
---
src/sms.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/sms.c b/src/sms.c
index 01f54dd..c4f8b54 100644
--- a/src/sms.c
+++ b/src/sms.c
@@ -47,6 +47,7 @@
#define SETTINGS_GROUP "Settings"
#define TXQ_MAX_RETRIES 4
+#define NETWORK_TIMEOUT 332
static gboolean tx_next(gpointer user_data);
@@ -630,6 +631,10 @@ static void tx_finished(const struct ofono_error *error, int mr,
void *data)
if (sms->registered == FALSE)
return;
+ /* Retry done only for Network Timeout failure */
+ if (error->error != NETWORK_TIMEOUT)
+ goto next_q;
+
Please also check error->type here to be CMS error.
if (!(entry->flags & OFONO_SMS_SUBMIT_FLAG_RETRY))
goto next_q;
Regards,
-Denis
4203
days inactive
4203
days old
2 comments
2 participants
participants (2)
-
Denis Kenzior -
Jeevaka Badrappan