Hi, changes in ofono_modem_set_powered() by this commit: http://git.kernel.org/?p=network/ofono/ofono.git;a=commit;h=b0f0e248e9c94... are now causing isimodem driver to crash: ofonod[13171]: src/modem.c:ofono_modem_driver_register() driver: 0x80ab578, name: isimodem ofonod[13171]: drivers/isimodem/isimodem.c:netlink_status_cb() PhoNet is up, addr=0x10, idx=0x14 ofonod[13171]: src/modem.c:ofono_modem_create() isimodem Program received signal SIGSEGV, Segmentation fault. 0x0807c197 in ofono_modem_set_powered () (gdb) bt #0 0x0807c197 in ofono_modem_set_powered () #1 0x08054ca8 in netlink_status_cb () #2 0x08052d84 in g_pn_nl_process () #3 0x00312d5b in ?? () from /lib/libglib-2.0.so.0 #4 0x002dbe78 in g_main_context_dispatch () from /lib/libglib-2.0.so.0 #5 0x002df720 in ?? () from /lib/libglib-2.0.so.0 #6 0x002dfb8f in g_main_loop_run () from /lib/libglib-2.0.so.0 #7 0x0807afeb in main () The patch to fix the problem is attached.

While the patch does indeed fix the issue, it does it mostly by accident. To add insult to injury it also has two style issues, all within 4 lines of code.

Hi Alex, > ext Denis Kenzior wrote: >> While the patch does indeed fix the issue, it does it mostly by accident. >> To add insult to injury it also has two style issues, all within 4 lines >> of code. > I must be blind. Which are the style issues exactly? We're very pedantic about spacing and blank lines here. There should be no extraneous blank spaces in the code. And all if statements must be preceded by a blank line.