1 a.m.
---
plugins/udevng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/plugins/udevng.c b/plugins/udevng.c
index ff6e1fc..d0a849d 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -1308,6 +1308,7 @@ static struct {
{ "calypso", setup_serial_modem },
{ "cinterion", setup_serial_modem },
{ "nokiacdma", setup_serial_modem },
+ { "sim800", setup_serial_modem },
{ "sim900", setup_serial_modem },
{ "wavecom", setup_wavecom },
{ "tc65", setup_tc65 },
--
2.7.4
1:02 a.m.
On 07/11/2018 15:00, Clement Viel wrote:
---
plugins/udevng.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/plugins/udevng.c b/plugins/udevng.c
index ff6e1fc..d0a849d 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -1308,6 +1308,7 @@ static struct {
{ "calypso", setup_serial_modem },
{ "cinterion", setup_serial_modem },
{ "nokiacdma", setup_serial_modem },
+ { "sim800", setup_serial_modem },
Right... that's much simpler. And given that you are extending the
sim900 driver to handle the sim800 model, you don't need the above line
either.
/Jonas
{ "sim900", setup_serial_modem },
{ "wavecom", setup_wavecom },
{ "tc65", setup_tc65 },
1:08 a.m.
On Wed, Nov 07, 2018 at 03:02:54PM +0100, Jonas Bonn wrote:
On 07/11/2018 15:00, Clement Viel wrote:
>---
> plugins/udevng.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/plugins/udevng.c b/plugins/udevng.c
>index ff6e1fc..d0a849d 100644
>--- a/plugins/udevng.c
>+++ b/plugins/udevng.c
>@@ -1308,6 +1308,7 @@ static struct {
> { "calypso", setup_serial_modem },
> { "cinterion", setup_serial_modem },
> { "nokiacdma", setup_serial_modem },
>+ { "sim800", setup_serial_modem },
Right... that's much simpler. And given that you are extending the sim900
driver to handle the sim800 model, you don't need the above line either.
/Jonas
> { "sim900", setup_serial_modem },
> { "wavecom", setup_wavecom },
> { "tc65", setup_tc65 },
>
I think I must keep this line because the udev rule added by the user will
specify that modem is "OFONO_DRIVER=sim800" so udevng.c must know what to do
with that.
3:59 a.m.
Hi Clement,
>> + { "sim800", setup_serial_modem }, > I think I
must keep this line because the udev rule added by the user
will specify that modem
is "OFONO_DRIVER=sim800" so udevng.c must know
what to do with that.
This is kind of weird that we have a driver line for a modem driver that
doesn't exist. We never do things this way. Why don't you just modify
the driver instructions to have OFONO_DRIVER=sim900 instead?
Also, we could simply rename the sim900 driver into sim_x00 or
simcom_serial or something too. That could make things a bit more clear.
Regards,
-Denis
1:16 a.m.
On Thu, Nov 08, 2018 at 10:59:30AM -0600, Denis Kenzior wrote:
Hi Denis,
Hi Clement,
>>>+ { "sim800", setup_serial_modem }, > I think I must keep this
line
>>>because the udev rule added by the user
will specify that modem is "OFONO_DRIVER=sim800" so udevng.c must know what
to do with that.
This is kind of weird that we have a driver line for a modem driver that
doesn't exist. We never do things this way. Why don't you just modify the
driver instructions to have OFONO_DRIVER=sim900 instead?
I agree with you, I was thinking the sim800 must be mentioned to avoid confusing
doc/sim900.txt to mention that sim800 is supported by this driver. Then, keep in
the users.
Also, we could simply rename the sim900 driver into sim_x00 or
simcom_serial
or something too. That could make things a bit more clear.
I think we can keep that in mind for further development.
Regards,
-Denis
Just tell me whether I should add mention of sim800 in sim900.txt or rename sim900.txt
in simcom.txt to mention the two drivers. Then I'll upload the patchset with doc in
it.
Regards
Clement
3:34 a.m.
Hi Clement,
Just tell me whether I should add mention of sim800 in sim900.txt or
rename sim900.txt
in simcom.txt to mention the two drivers. Then I'll upload the patchset with doc in
it.
I don't feel strongly either way, but if I had to pick, I say lets
rename sim900.txt into simcom.txt and maintain all driver instructions
there.
Regards,
-Denis
1:21 a.m.
On Thu, Nov 08, 2018 at 10:59:30AM -0600, Denis Kenzior wrote:
Hi Clement,
>>>+ { "sim800", setup_serial_modem }, > I think I must keep this
line
>>>because the udev rule added by the user
will specify that modem is "OFONO_DRIVER=sim800" so udevng.c must know what
to do with that.
This is kind of weird that we have a driver line for a modem driver that
doesn't exist. We never do things this way. Why don't you just modify the
driver instructions to have OFONO_DRIVER=sim900 instead?
Also, we could simply rename the sim900 driver into sim_x00 or simcom_serial
or something too. That could make things a bit more clear.
Regards,
-Denis
Moreover if we go for the OFONO_DRIVER=sim900 solution, plugins/udevng.c will stay
the same.
1406
days inactive
1411
days old
6 comments
3 participants
participants (3)
-
Clement Viel -
Denis Kenzior -
Jonas Bonn