Hi Denis,
On Thu, Mar 28, 2013 at 11:05:38AM -0500, Denis Kenzior wrote:
On 03/28/2013 10:36 AM, Forest Bond wrote:
>On Thu, Mar 28, 2013 at 09:55:25AM -0500, Denis Kenzior wrote:
>>On 03/28/2013 09:22 AM, Forest Bond wrote:
>>>From: Forest Bond<forest.bond(a)rapidrollout.com>
>>>
>>>---
>>> src/modem.c | 15 +++++++++++++--
>>> 1 files changed, 13 insertions(+), 2 deletions(-)
>>>
>>
>>I would actually be okay with this as an interim solution, but see
>>my comments to patch 3.
>
>Great, glad to hear it.
>
>Quick question: Once this change is in place, set_online is not called for CDMA
>devices. Should I kill the CDMA-only code paths there?
I don't recall off hand which code paths these are. Can you elaborate?
Sorry, I guess I was thinking of the sierra plugin. In the huawei plugin the
only candidate for removal would be this chunk in rfswitch_support:
if (data->have_gsm == FALSE && data->have_cdma == TRUE) {
data->offline_command = "AT+CFUN=5";
goto done;
}
But I guess we might as well leave that.
Thanks,
Forest
--
Forest Bond
http://www.alittletooquiet.net
http://www.rapidrollout.com