11:22 p.m.
Telit does not support AT+CGAUTO, use AT#AUTOATT=0 instead.
---
drivers/atmodem/gprs.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index 65a8b7b..f87548e 100644
--- a/drivers/atmodem/gprs.c
+++ b/drivers/atmodem/gprs.c
@@ -342,7 +342,13 @@ retry:
goto error;
g_at_chat_send(gd->chat, cmd, none_prefix, NULL, NULL, NULL);
- g_at_chat_send(gd->chat, "AT+CGAUTO=0", none_prefix, NULL, NULL, NULL);
+
+ /* Telit does not support AT+CGAUTO */
+ if (gd->vendor == OFONO_VENDOR_TELIT)
+ cmd = "AT#AUTOATT=0";
+ else
+ cmd = "AT+CGAUTO=0";
+ g_at_chat_send(gd->chat, cmd, none_prefix, NULL, NULL, NULL);
switch (gd->vendor) {
case OFONO_VENDOR_MBM:
--
1.7.7.6
--
Scanned by MailScanner.
11:36 p.m.
Hi Christopher,
On 08/13/2012 08:22 AM, Christopher Vogl wrote:
Telit does not support AT+CGAUTO, use AT#AUTOATT=0 instead.
---
drivers/atmodem/gprs.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index 65a8b7b..f87548e 100644
--- a/drivers/atmodem/gprs.c
+++ b/drivers/atmodem/gprs.c
@@ -342,7 +342,13 @@ retry:
goto error;
g_at_chat_send(gd->chat, cmd, none_prefix, NULL, NULL, NULL);
- g_at_chat_send(gd->chat, "AT+CGAUTO=0", none_prefix, NULL, NULL, NULL);
+
+ /* Telit does not support AT+CGAUTO */
+ if (gd->vendor == OFONO_VENDOR_TELIT)
+ cmd = "AT#AUTOATT=0";
+ else
+ cmd = "AT+CGAUTO=0";
+ g_at_chat_send(gd->chat, cmd, none_prefix, NULL, NULL, NULL);
Actually the two command indents are different. CGAUTO means do not auto
accept network initiated PDP context activation requests. Refer to
Section 10.1.15 in 3GPP 27.007. It is fine to ignore it if it is not
supported.
The #AUTOATT=0 tells the modem not to automatically initiate auto-attach
proceedures on its own. This is correct, but probably belongs in the
main telit plugin.
switch (gd->vendor) {
case OFONO_VENDOR_MBM:
Regards,
-Denis
7:33 p.m.
New subject: [PATCH] gprs: skip CGAUTO for telit
Telit does not support +CGAUTO and will just return an error.
To not confuse people reading the debug output, don't send the command
for telit.
---
drivers/atmodem/gprs.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index 65a8b7b..4e0823c 100644
--- a/drivers/atmodem/gprs.c
+++ b/drivers/atmodem/gprs.c
@@ -342,7 +342,11 @@ retry:
goto error;
g_at_chat_send(gd->chat, cmd, none_prefix, NULL, NULL, NULL);
- g_at_chat_send(gd->chat, "AT+CGAUTO=0", none_prefix, NULL, NULL, NULL);
+
+ if (gd->vendor == OFONO_VENDOR_TELIT)
+ DBG("Telit does not support +CGAUTO command.");
+ else
+ g_at_chat_send(gd->chat, "AT+CGAUTO=0", none_prefix, NULL, NULL, NULL);
switch (gd->vendor) {
case OFONO_VENDOR_MBM:
--
1.7.7.6
--
Scanned by MailScanner.
4:24 p.m.
New subject: [PATCH] gprs: skip CGAUTO for telit
Hi Christopher,
On 08/16/2012 04:33 AM, Christopher Vogl wrote:
Telit does not support +CGAUTO and will just return an error.
To not confuse people reading the debug output, don't send the command
for telit.
---
drivers/atmodem/gprs.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c
index 65a8b7b..4e0823c 100644
--- a/drivers/atmodem/gprs.c
+++ b/drivers/atmodem/gprs.c
@@ -342,7 +342,11 @@ retry:
goto error;
g_at_chat_send(gd->chat, cmd, none_prefix, NULL, NULL, NULL);
- g_at_chat_send(gd->chat, "AT+CGAUTO=0", none_prefix, NULL, NULL, NULL);
+
+ if (gd->vendor == OFONO_VENDOR_TELIT)
+ DBG("Telit does not support +CGAUTO command.");
+ else
+ g_at_chat_send(gd->chat, "AT+CGAUTO=0", none_prefix, NULL, NULL, NULL);
What are you gaining by printing the above message and not sending the
CGAUTO?
switch (gd->vendor) {
case OFONO_VENDOR_MBM:
Regards,
-Denis
3685
days inactive
3688
days old
3 comments
2 participants
participants (2)
-
Christopher Vogl -
Denis Kenzior