1:28 a.m.
Hello,
This took a while to locate. Shouldn't it be possible to use stty
outside the daemon, and then daemon would just continue as usual?
In my case, the cread was being removed, so no input data could be read.
Thanks,
Ryan
Signed-off-by: Ryan M. Raasch <ryan.raasch(a)gmail.com>
---
gatchat/gattty.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
4:32 a.m.
New subject: [PATCH] When setting the serial port, the previous settings need to be preserved.
Hi Ryan,
This took a while to locate. Shouldn't it be possible to use
stty
outside the daemon, and then daemon would just continue as usual?
In my case, the cread was being removed, so no input data could be read.
Sorry but the patch is wrong, since you're blowing away all options that have
been set via the GHashTable.
GAtTty is really a convenience method, if you need something specific, pass the
option in the GHashTable or setup the fd however you wish by yourself.
Regards,
-Denis
6:43 p.m.
New subject: [PATCH] When setting the serial port, the previous settings need to be preserved.
Denis Kenzior wrote:
Hi Ryan,
> This took a while to locate. Shouldn't it be possible to use stty
> outside the daemon, and then daemon would just continue as usual?
>
> In my case, the cread was being removed, so no input data could be read.
Sorry but the patch is wrong, since you're blowing away all options that have
been set via the GHashTable.
Yea. Sorry. Put it in the wrong place, uggh. It should go before setting
the options, since the switches are or'ing and xor'ing.
GAtTty is really a convenience method, if you need something specific, pass the
option in the GHashTable or setup the fd however you wish by yourself.
Regards,
-Denis
But, there is a problem with the opening of the serial port b/c the
CREAD flag is destroyed if it is active, making the serial port unreadable.
Ryan
_______________________________________________
ofono mailing list
ofono(a)ofono.org
http://lists.ofono.org/listinfo/ofono
8:10 p.m.
New subject: [PATCH] When setting the serial port, the previous settings need to be preserved.
Sorry. I have had a long few days. The last patch was just COMPLETELY
wrong :(
I think i got it right this time...
Apologies,
Ryan
Ryan Raasch wrote:
Denis Kenzior wrote:
> Hi Ryan,
>
>> This took a while to locate. Shouldn't it be possible to use stty
>> outside the daemon, and then daemon would just continue as usual?
>>
>> In my case, the cread was being removed, so no input data could be read.
>
> Sorry but the patch is wrong, since you're blowing away all options
> that have been set via the GHashTable.
Yea. Sorry. Put it in the wrong place, uggh. It should go before setting
the options, since the switches are or'ing and xor'ing.
>
> GAtTty is really a convenience method, if you need something specific,
> pass the option in the GHashTable or setup the fd however you wish by
> yourself.
>
> Regards,
> -Denis
But, there is a problem with the opening of the serial port b/c the
CREAD flag is destroyed if it is active, making the serial port unreadable.
Ryan
> _______________________________________________
> ofono mailing list
> ofono-bdc2hr5oBkPYtjvyW6yDsg(a)public.gmane.org
> http://lists.ofono.org/listinfo/ofono
2:13 a.m.
New subject: [PATCH] When setting the serial port, the previous settings need to be preserved.
Hi Ryan,
Sorry. I have had a long few days. The last patch was just
COMPLETELY
wrong :(
I think i got it right this time...
So the patch is still wrong :)
memset(&ti, 0, sizeof(ti));
cfmakeraw(&ti);
+ fd = open(tty, O_RDWR | O_NOCTTY | O_NONBLOCK);
+ if (fd < 0)
+ return -1;
+
+ tcgetattr(fd,&ti);
+
You're blowing away the result of cfmakeraw. Most of the devices are not true
serial devices and so do not need any of the special options. Passing a NULL
options GHashTable should result in cfmakeraw. Why don't you just pass all
the options you need instead of using tcgetattr?
The other parts of the patch look good to me.
Regards,
-Denis
2:51 a.m.
New subject: [PATCH] When setting the serial port, the previous settings need to be preserved.
Denis Kenzior wrote:
Hi Ryan,
> Sorry. I have had a long few days. The last patch was just COMPLETELY
> wrong :(
>
> I think i got it right this time...
So the patch is still wrong :)
memset(&ti, 0, sizeof(ti));
cfmakeraw(&ti);
+ fd = open(tty, O_RDWR | O_NOCTTY | O_NONBLOCK);
+ if (fd < 0)
+ return -1;
+
+ tcgetattr(fd,&ti);
+
You're blowing away the result of cfmakeraw. Most of the devices are not true
serial devices and so do not need any of the special options. Passing a NULL
options GHashTable should result in cfmakeraw. Why don't you just pass all
the options you need instead of using tcgetattr?
Should i just move the tcgetattr() to happen before cfmakeraw()?
The other parts of the patch look good to me.
Ok. Why don't i just add the string options ("read", others...) in
gattty.c?
Thanks,
Ryan
Regards,
-Denis
_______________________________________________
ofono mailing list
ofono(a)ofono.org
http://lists.ofono.org/listinfo/ofono
2:36 a.m.
New subject: [PATCH] When setting the serial port, the previous settings need to be preserved.
Hi Ryan,
> You're blowing away the result of cfmakeraw. Most of the
devices are not
> true serial devices and so do not need any of the special options.
> Passing a NULL options GHashTable should result in cfmakeraw. Why don't
> you just pass all the options you need instead of using tcgetattr?
Should i just move the tcgetattr() to happen before cfmakeraw()?
Only one (executed last) will have effect, and I want it to be the cfmakeraw.
So simply get rid of tcgetattr.
> The other parts of the patch look good to me.
Ok. Why don't i just add the string options ("read", others...) in
gattty.c?
This is what I would prefer.
Regards,
-Denis
7:43 p.m.
New subject: [PATCH] When setting the serial port, the previous settings need to be preserved.
Hello,
I have attached a small patch which allows gattty.c to enable/disable
the read functionality on the serial port.
Cheers,
Ryan
Denis Kenzior wrote:
Hi Ryan,
>> You're blowing away the result of cfmakeraw. Most of the devices are not
>> true serial devices and so do not need any of the special options.
>> Passing a NULL options GHashTable should result in cfmakeraw. Why don't
>> you just pass all the options you need instead of using tcgetattr?
> Should i just move the tcgetattr() to happen before cfmakeraw()?
Only one (executed last) will have effect, and I want it to be the cfmakeraw.
So simply get rid of tcgetattr.
>> The other parts of the patch look good to me.
> Ok. Why don't i just add the string options ("read", others...) in
> gattty.c?
This is what I would prefer.
Regards,
-Denis
_______________________________________________
ofono mailing list
ofono(a)ofono.org
http://lists.ofono.org/listinfo/ofono
4714
days inactive
4717
days old
8 comments
2 participants
participants (2)
-
Denis Kenzior -
Ryan Raasch