2:35 a.m.
Hi,
As per the specification, if the alpha identifier is provided by the UICC
and is a null data object (i.e. length = '00' and no value part), this is an
indication that the terminal should not give any information to the user.
Regards,
Jeevaka
Jeevaka Badrappan (2):
stk: fix issue with null data object
stkutil: fix issue with null data object
src/stk.c | 2 +-
src/stkutil.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
2:35 a.m.
New subject: [PATCH 1/2] stk: fix issue with null data object
As per the specification, if alphad identifier is
provided and is a null data object, no information
should be given to the user.
---
src/stk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/stk.c b/src/stk.c
index e933e4e..3d736dd 100644
--- a/src/stk.c
+++ b/src/stk.c
@@ -484,7 +484,7 @@ static void stk_alpha_id_set(struct ofono_stk *stk,
* and no alpha identifier cases equally. This may be changed once
* better idea is found out.
*/
- if (alpha != NULL)
+ if (alpha != NULL && alpha[0] != '\0')
stk_agent_display_action_info(stk->current_agent, alpha, icon);
g_free(alpha);
--
1.7.0.4
4:12 p.m.
New subject: [PATCH 1/2] stk: fix issue with null data object
Hi Jeevaka
On 7 March 2011 16:35, Jeevaka Badrappan
<jeevaka.badrappan(a)elektrobit.com> wrote:
As per the specification, if alphad identifier is
provided and is a null data object, no information
should be given to the user.
What do do you think of the following change?
diff --git a/src/stkutil.c b/src/stkutil.c
index abd1c99..c64cb7a 100644
--- a/src/stkutil.c
+++ b/src/stkutil.c
@@ -309,7 +309,7 @@ static gboolean parse_dataobj_alpha_id(struct
comprehension_tlv_iter *iter,
len = comprehension_tlv_iter_get_length(iter);
if (len == 0) {
- *alpha_id = g_try_malloc0(1);
+ *alpha_id = NULL;
return TRUE;
}
This actually lets the caller detect a NULL alpha identifier and then,
as far as I can see, the stk.c code will not give any information to
the user if either the alpha_id is NULL or not provided.
Best regards
11:05 p.m.
New subject: [PATCH 1/2] stk: fix issue with null data object
Hi Andrew,
Andrzej Zaborowski wrote:
Hi Jeevaka
On 7 March 2011 16:35, Jeevaka Badrappan
<jeevaka.badrappan(a)elektrobit.com> wrote:
> As per the specification, if alphad identifier is provided and is a
> null data object, no information should be given to the user.
What do do you think of the following change?
diff --git a/src/stkutil.c b/src/stkutil.c index
abd1c99..c64cb7a 100644
--- a/src/stkutil.c
+++ b/src/stkutil.c
@@ -309,7 +309,7 @@ static gboolean
parse_dataobj_alpha_id(struct comprehension_tlv_iter *iter,
len = comprehension_tlv_iter_get_length(iter); if
(len == 0) { - *alpha_id = g_try_malloc0(1);
+ *alpha_id = NULL;
return TRUE;
}
This actually lets the caller detect a NULL alpha identifier
and then, as far as I can see, the stk.c code will not give
any information to the user if either the alpha_id is NULL or not
provided.
Change is fine with me.
Regards,
Jeevaka
2:35 a.m.
New subject: [PATCH 2/2] stkutil: fix issue with null data object
---
src/stkutil.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/stkutil.c b/src/stkutil.c
index abd1c99..66b2924 100644
--- a/src/stkutil.c
+++ b/src/stkutil.c
@@ -308,7 +308,7 @@ static gboolean parse_dataobj_alpha_id(struct comprehension_tlv_iter
*iter,
char *utf8;
len = comprehension_tlv_iter_get_length(iter);
- if (len == 0) {
+ if (len <= 1) {
*alpha_id = g_try_malloc0(1);
return TRUE;
}
--
1.7.0.4
10:54 a.m.
New subject: [PATCH 2/2] stkutil: fix issue with null data object
Hi Jeevaka,
On 7 March 2011 16:35, Jeevaka Badrappan
<jeevaka.badrappan(a)elektrobit.com> wrote:
---
src/stkutil.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/stkutil.c b/src/stkutil.c
index abd1c99..66b2924 100644
--- a/src/stkutil.c
+++ b/src/stkutil.c
@@ -308,7 +308,7 @@ static gboolean parse_dataobj_alpha_id(struct comprehension_tlv_iter
*iter,
char *utf8;
len = comprehension_tlv_iter_get_length(iter);
- if (len == 0) {
+ if (len <= 1) {
*alpha_id = g_try_malloc0(1);
In the description you talk about Length == 00 and no value part but
this change affects the case of Length == 1, which I think we're
handling correctly already. What is the exact problem case?
I'm not sure but I think we already considered an identical patch, but
in the spec there's nothing special about this case so I think the
zero-length string needs to be sent to the user like any other string.
Best regards
1:48 p.m.
New subject: [PATCH 2/2] stkutil: fix issue with null data object
Hi Andrew,
ofono-bounces(a)ofono.org wrote:
Hi Jeevaka,
On 7 March 2011 16:35, Jeevaka Badrappan
<jeevaka.badrappan(a)elektrobit.com> wrote:
> ---
> src/stkutil.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/stkutil.c b/src/stkutil.c index abd1c99..66b2924
> 100644 --- a/src/stkutil.c
> +++ b/src/stkutil.c
> @@ -308,7 +308,7 @@ static gboolean parse_dataobj_alpha_id(struct
> comprehension_tlv_iter *iter, char *utf8;
>
> len = comprehension_tlv_iter_get_length(iter); - if
> (len == 0) { + if (len <= 1) {
> *alpha_id = g_try_malloc0(1);
In the description you talk about Length == 00 and no value
part but this change affects the case of Length == 1, which I
think we're handling correctly already. What is the exact problem
case?
I'm not sure but I think we already considered an identical
patch, but in the spec there's nothing special about this
case so I think the zero-length string needs to be sent to
the user like any other string.
Agree, empty string case is already covered. Just confused myself.
Patch can be ignored as this is already covered.
Regards,
Jeevaka
4209
days inactive
4213
days old
6 comments
3 participants
participants (3)
-
Andrzej Zaborowski -
Jeevaka Badrappan -
Jeevaka.Badrappan＠elektrobit.com