We prefer if you use git send-email to format the patch for submission.

I think the better way would be to drop a udev rule directly into /etc/udev.d or similar. The rule should be as simple as: KERNEL=="ttySAC0", ENV{OFONO_DRIVER}="calypso"

Let me know if this works for you and I can add a comment in the calypso plugin.

>> I think the better way would be to drop a udev rule directly into >> /etc/udev.d or similar. The rule should be as simple as: >> KERNEL=="ttySAC0", ENV{OFONO_DRIVER}="calypso" > > Do you mean in another file than 97-ofono.rules? Yep.

> We could document this as Freerunner specific notes to point people into > the right direction. And we should maybe to the same for IFX since that > is currently only documented in the GIT commit logs. Documentation inside the individual modem driver is the way to go. And IFX isn't even documented in git commit logs. I looked ;)

>>> We could document this as Freerunner specific notes to point people into >>> the right direction. And we should maybe to the same for IFX since that >>> is currently only documented in the GIT commit logs. >> >> Documentation inside the individual modem driver is the way to go. And >> IFX isn't even documented in git commit logs. I looked ;) > > commit 3443a7a177fbaca24c84658968aff0a55db8a51d > Author: Marcel Holtmann <marcel(a)holtmann.org&gt; > Date: Sat Sep 18 22:08:41 2010 +0900 > > udev: Add support for IFX device detection > > The IFX device detection is pretty static, but instead of using > a static configuration file it is important to know when the device > node is actually present. For this udev is perfect. Adding a simple > udev rule is all that it takes: > > KERNEL=="ttyIFX[0-9]*", ENV{OFONO_DRIVER}="ifx" > > With this rule for every TTY with the kernel name like ttyIFX0, a new > modem will be added and the IFX modem plugin driver requested for it. > > this is not enough? Then I didn't look far back enough (or I'm simply blind). But I still prefer this to be inside the driver or HACKING.calypso for easier access.

Hi Marcel, >> Then I didn't look far back enough (or I'm simply blind). But I still >> prefer this to be inside the driver or HACKING.calypso for easier access. > > I am with you that this needs to be documented better than GIT commit > logs. > > However I do prefer doc/calypso-modem.txt and doc/ifx-modem.txt though > since I don't wanna clutter the root directory. > Sounds good to me.

Hi Neil, > (I don't yet understand why it makes sense for calypso to be handled > differently from other cases in plugins/ofono.rules, but I'm happy to > trust that there is a good reason for this.) the other cases come from an unique vendor and product ID. The Calypso and also IFX modems are based on device nodes. These are not unique. They are platform specific. Not all platform will have a Calypso modem behind /dev/ttySAC0 for example.