October 2014 - PowerTOP

error when auto-tune on last git (Sept 30th)

by sheepdestroyer

Just compiled last available source from Github I get this error on fedora 20 when trying auto-tune $ sudo powertop --auto-tune Loaded 750 prior measurements RAPL device for cpu 0 RAPL device for cpu 0 RAPL device for cpu 0 unknown op '{' Leaving PowerTOP $ Best

7 years, 10 months

2
2
0 / 0

[PATCH 00/14] pull: various changes, mostly build system related

by Sami Kerola

Hello, Here is my next random collection of various small changes here and there in source tree. Many of the changes has relation to build system, and the remainign one are reactions to compiler complaints found after build system teaks. I hope these changes are reviewed before next release, and in best case they might even be part of it. ---------------------------------------------------------------- The following changes since commit 41c54e81145a0f35c2bd576a0ee57c3844dee710: allow none-ncurses messaging with ui_notify_user() (2014-09-29 11:34:25 -0700) are available in the git repository at: git://github.com/kerolasa/powertop.git various for you to fetch changes up to e6663e420abb526523fa1a7fda42661801480155: add missing include (2014-10-25 11:16:36 +0100) ---------------------------------------------------------------- Sami Kerola (14): configure: require the least automake version 1.11.1 configure: use autoconf-archive ax_pthread.m4 add missing space to --version print out csstoh.sh: check every single return value configure: use AC_USE_SYSTEM_EXTENSIONS to determine features powertop.m4: GCC_FORTIFY_SOURCE_CC copy idea of macro from Archlinux pacman configure: use autoconf-archive ax_cxx_compile_stdcxx_11.m4 main: fix incompatible operand type move variables to protected scope make --quiet option to suppress various info messages squeeze all extra bits from size of binary and html report add timestamp to html report fix typo in message add missing include .gitignore | 39 +++- PowerTop.png | Bin 6975 -> 5542 bytes configure.ac | 21 ++- m4/ax_cxx_compile_stdcxx_11.m4 | 142 +++++++++++++++ m4/ax_pthread.m4 | 332 +++++++++++++++++++++++++++++++++++ m4/gcc_fortify_source_cc.m4 | 29 +++ src/Makefile.am | 1 - src/cpu/rapl/rapl_interface.cpp | 7 +- src/cpu/rapl/rapl_interface.h | 9 +- src/csstoh.sh | 40 +++-- src/lib.h | 1 + src/main.cpp | 8 +- src/report/report-formatter-base.cpp | 2 - src/report/report-formatter-csv.cpp | 2 - src/report/report-formatter-html.cpp | 248 +++++++++++++------------- src/report/report.cpp | 5 +- 16 files changed, 719 insertions(+), 167 deletions(-) create mode 100644 m4/ax_cxx_compile_stdcxx_11.m4 create mode 100644 m4/ax_pthread.m4 create mode 100644 m4/gcc_fortify_source_cc.m4 -- 2.1.2

7 years, 10 months

3
18
0 / 0

Re: [Powertop] Completion of error handling

by SF Markus Elfring

> This is a good idea, please send your patches with the fixes. I suggest to avoid ignorance of return values a bit more. https://cwe.mitre.org/data/definitions/252 Are you interested to apply aspect-oriented software development? How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software? https://en.wikipedia.org/wiki/Aspect_%28computer_programming%29 Regards, Markus

7 years, 10 months

3
4
0 / 0

Deletion of unnecessary checks before specific function calls

by SF Markus Elfring

Hello, I suggest to delete redundant checks for null pointers. Would you like to integrate the attached update suggestion into your source code repository? Regards, Markus

7 years, 10 months

3
3
0 / 0

reserved identifier violation

by SF Markus Elfring

Hello, I would like to point out that identifiers like "__INCLUDE_GUARD_DISPLAY_H_" and "_INCLUDE_GUARD_AHCI_H" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names? https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.... https://github.com/fenrus75/powertop/blob/54956f7407c0e369665cd9712a189f6... https://github.com/fenrus75/powertop/blob/d7455ba1d0125efed4780a2114ef661... Regards, Markus

7 years, 10 months

2
4
0 / 0

Complete build options for Pthread API

by SF Markus Elfring

Hello, Would you like to add the configuration script "AX_PTHREAD" to your build specification? http://www.gnu.org/software/autoconf-archive/ax_pthread.html https://github.com/fenrus75/powertop/blob/86eda5c0851935d5315f604599a0e8f... Regards, Markus

7 years, 10 months

4
15
0 / 0

PowerTop 2.7 Schedule

by Alexandra Yates

All, Here is the schedule for PowerTOP next release: PowerTOP v2.7 * Oct 31th (string freeze) * Nov 14th (code freeze v2.7) * Nov 21st (release v2.7) Please budget to send your patches, bug fixes, and test accordingly. Thank you, Alexandra.

7 years, 11 months

1
1
0 / 0

Re: [Powertop] Package C states over Haswell platform

by Alexandra Yates

> >> Hi, >> >> I'm working on DELL E7440 platform (Haswell based) with dual OS: Windows >> 8.1 >> and Ubuntu 14.04.1 (based on 3.13). >> When I use Win 8.1, using BLA I get ~90% PC7 when idle. However, when I >> use >> the Ubuntu, using powertop I get only as high as PC3. >> Since it's the same platform, it seems to rule out a HW issue. Any idea >> what >> can be the problem? Is Haswell fully supported by powertop? >> >> Package | Core | CPU 0 CPU 2 >> | | C0 active 0.2% 0.1% >> | | POLL 0.0% 0.0 ms >> 0.0% >> 0.0 ms >> | | C1E-HSW 0.0% 0.1 ms >> 0.0% >> 0.0 ms >> C2 (pc2) 0.1% | | >> C3 (pc3) 3.7% | C3 (cc3) 0.0% | C3-HSW 0.0% 0.4 ms >> 0.0% >> 0.4 ms >> C6 (pc6) 0.0% | C6 (cc6) 0.0% | C6-HSW 0.0% 0.0 ms >> 0.0% >> 0.2 ms >> C7 (pc7) 0.0% | C7 (cc7) 99.0% | C7s-HSW 0.1% 0.9 ms >> 0.1% >> 1.8 ms >> C8 (pc8) 0.0% | | C8-HSW 0.1% 1.4 ms >> 0.2% >> 2.5 ms >> C9 (pc9) 0.0% | | C9-HSW 0.4% 4.0 ms >> 2.3% >> 8.0 ms >> C10 (pc10) 0.0% | | C10-HSW 98.9% 44.5 ms >> 97.0% >> 36.5 ms >> >> | Core | CPU 1 CPU 3 >> | | C0 active 0.2% 0.1% >> | | POLL 0.0% 0.0 ms >> 0.0% >> 0.0 ms >> | | C1E-HSW 0.0% 0.0 ms >> 1.0% >> 50.1 ms >> | | >> | C3 (cc3) 0.0% | C3-HSW 0.0% 0.7 ms >> 0.0% >> 0.6 ms >> | C6 (cc6) 0.0% | C6-HSW 0.0% 0.5 ms >> 0.0% >> 0.0 ms >> | C7 (cc7) 98.0% | C7s-HSW 0.1% 0.7 ms >> 0.4% >> 25.7 ms >> | | C8-HSW 0.0% 4.9 ms >> 0.0% >> 1.5 ms >> | | C9-HSW 0.6% 4.7 ms >> 0.7% >> 19.5 ms >> | | C10-HSW 98.5% 93.5 ms >> 97.8% >> 78.0 ms >> >> | GPU | >> | | >> | Powered On 12.1% | >> | RC6 87.9% | >> | RC6p 0.0% | >> | RC6pp 0.0% | >> >> Thanks >> >> >> >> Rony >> >> _______________________________________________ >> PowerTop mailing list >> PowerTop(a)lists.01.org >> https://lists.01.org/mailman/listinfo/powertop >> Hi Rony, Interesting you ask this since I presented at the Open source bridge conference a case study on how to optimize your computer in terms of power using PowerTOP, as an example I used a Haswell box with Ubuntu. I also presented on the Debian conference a similar talk using Debian distro. Both talks happened this year. There are few things that may be happening. 1- Update to the latest kernel 3.17. From 3.13 to 3.17 there have been few bug fixes that help linux in terms of power management. 2-At the boot command line of your kernel add the following settings: i915.enable_psr=1 i915.enable_fbc=1 pcie_aspm=force The first command enables the graphics card use panel self refresh, the second enables frame buffer compression. The third command helps the network card enter D3 state. http://wireless.kernel.org/en/users/Documentation/ASPM#Enabling_ASPM_with... 3- Use PowerTOP/tunables to tune power management for all your devices. If none of the settings disrupt the proper usability of the computer add then to a script file and run this each time you restart your computer. Alternatively you can use powertop --auto_tune Run PowerTOP at this point you should see your system reaching a deep power state. Thank you, Alexandra.

7 years, 11 months

2
1
0 / 0

Package C states over Haswell platform

by Rony Ross

7 years, 11 months

4
3
0 / 0

A series of patches towards limiting memory corruption and foot print

by Kalowsky, Daniel

Hi Powertop, I've been working with the interactive mode and have run into cases where powertop will crash due to a series of memory corruptions. The following series of patches have helped to reduce the frequency of the issue, although not completely solved it. The issues arise much faster on platforms where there are constrained amounts of RAM to work within. Patch 1 - When shutting down the interactive display, the display bits of memory is not correctly released. This patch provides a method for correctly doing so. Patch 2 - Solving a documented memory leak with a non-elegant solution. The path either adds the bundle to the stack, or it forgets about it. If it is forgotten about, make sure to clear that memory before moving on. This is done with a simple flag variable being set. Patch 3 - When the tuning window is updated, the current pointer is just set adrift and not properly free'd. This patch catches that issue and removes the dangling pointer by holding a reference to the pointer until it is reset or specifically free'd. Patch 4 - Someone actually added in the code to create a onetime pretty-print array, this patch just puts it to use by setting the variable. Patch 5 - Limiting the buffer copy to the size of the allocated buffer with snprintf. Patch 6 - There exist some processes and entries that can and do extend beyond the length of these buffers. This limits those entries so as not to corrupt other memory on the system when in interactive mode. Patch 7 - This is an untested patch, but follows along the same lines of Patch 6. It applies the same principals only for the report method. Patch 8 - Creates a clean_shutdown function that can be used to cleanup the memory space at shutdown time. Calls upon parts of Patch 1 to make this happen. There will more than likely be some more patches in the future as time permits.

7 years, 11 months

6
40
0 / 0

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

PowerTOP October 2014