[PATCH] Makefile.am need reference to m4 directory
by Daniel Black
Running autoreconf (autconf-2.69/automake-1.15/libtoolize-2.4.6)
without the m4 directory specified in the Makefile.am file generates
the following warning:
./autogen.sh
autoreconf: Entering directory `.'
autoreconf: running: autopoint
autoreconf: running: aclocal
autoreconf: configure.ac: tracing
autoreconf: running: libtoolize --copy
libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
autoreconf: running: /usr/bin/autoconf
autoreconf: running: /usr/bin/autoheader
autoreconf: running: automake --add-missing --copy --no-force
configure.ac:26: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and
its use is discouraged.
configure.ac:26: You should use the Autoconf-provided 'AC_PROG_MKDIR_P'
macro instead,
configure.ac:26: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your
Makefile.am files.
autoreconf: Leaving directory `.'
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index c8d0ae2..a9cf9db 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,4 +1,5 @@
AUTOMAKE_OPTIONS = subdir-objects
+ACLOCAL_AMFLAGS=-I m4
SUBDIRS = \
traceevent \
--
2.7.4
5 years, 11 months
[PATCH] Fix misaligned curly brace
by Oleg Drokin
This brace makes it look like the wrong block is beign closed
causing some confusion for the reader.
Signed-off-by: Oleg Drokin <green(a)linuxhacker.ru>
---
src/devlist.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/devlist.cpp b/src/devlist.cpp
index e6a4f4c..70ae70e 100644
--- a/src/devlist.cpp
+++ b/src/devlist.cpp
@@ -196,7 +196,7 @@ int charge_device_to_openers(const char *devstring, double power, class device *
for (i = 0; i < one.size(); i++) {
if (strstr(one[i]->device, devstring))
openers++;
- }
+ }
for (i = 0; i < two.size(); i++) {
if (strstr(two[i]->device, devstring))
openers++;
--
2.7.4
6 years
[PATCH 0/2] Show evil usbdevfs users
by Oleg Drokin
It turns out that powertop does not yet recognise that usbdevfs
users that hold usb device open like that cause it to operate at full
power, kind of like ALSA sound device users.
So the first patch adds support for ussbdevfs users to shame them
for needlessly draining power (I am looking at you, fwupd), and
patch two fixes an issue where such processes are not displayed in the
summary because they did not have any runtime at all, as if that would
somehow prevent the device-opening-damage.
Oleg Drokin (2):
Add support for usbdevfs
Show idle processes holding devices at full power
src/devices/usb.cpp | 28 ++++++++++++++++++++++++++++
src/devices/usb.h | 3 +++
src/process/process.cpp | 3 ++-
3 files changed, 33 insertions(+), 1 deletion(-)
--
2.7.4
6 years
[PATCH 0/2 v1] intel_cpus: average cpu frequency, dnd some idle data
by Joe Konno
From: Joe Konno <joe.konno(a)intel.com>
The first patch in this series makes a cosmetic change to the Frequency Stats
tab for Intel end-users. "Actual" cpu frequency will be changed to "Average",
which is a more accurate representation of that data (since it displays the
average cpu frequency for the sampling period). The underlying algorithms which
generate this data remain unchanged.
The second patch will add a condition to the Frequency Stats tab "Idle"
display, which will _not_ display "Idle" data if the intel_pstate kernel driver
(not cpufreq) is loaded. Only the average frequency of each logical core for
the sample period will be displayed (if intel_pstate is loaded).
With intel_pstate, Idle data for the Frequency Stats tab is inferred from
cpu_frequency PM trace events. There have been particular workloads where
PowerTOP may display 100% idle (in Frequency Stats) for the sampling period
despite logical cores doing work. Further, Frequency Stats' 'idle' data may not
match idle data presented in the Idle Stats tab. This is a bug, and is the
justification for patch 2 in this series.
After this patch series is committed, end-users who load the intel_pstate
driver are directed to perform idle analysis on data gathered from the Idle
Stats tab, as the Frequency Stats tab will only provide average logical core
frequency for the sampling period. It may be possible to bring idle statistics
back to the Frequency Stats tab for intel_pstate in the future, but only after
careful re-examination of Frequency Stats' idle calculations.
Joe Konno (2):
intel_cpus: frequency: clarify average clock speed
intel_cpus: no pstate Idle pct with intel_pstate
src/cpu/intel_cpus.cpp | 52 ++++++++++++++++++++++++++++++++++++++++++--------
src/cpu/intel_cpus.h | 2 ++
2 files changed, 46 insertions(+), 8 deletions(-)
--
2.8.3
6 years
[PATCH 0/1 v1] Have git ignore editor and tool files
by Joe Konno
From: Joe Konno <joe.konno(a)intel.com>
Simple patch to .gitignore which ignores files output by vim, cscope, and
ctags.
Did a sanity check with 'git ls-files -i --exclude-standard' after applying
this patch and no red flags raised.
Joe Konno (1):
.gitignore: ignore vim swap, cscope, ctags
.gitignore | 3 +++
1 file changed, 3 insertions(+)
--
2.8.3
6 years
