Re: [Powertop] [RFC][PATCH 1/2] Adding report generator facility
On (10/03/12 21:05), Igor Zhbanov wrote:
---
po/Makevars | 2 +-
src/Makefile.am | 4 +
src/report/report-formatter-csv.cpp | 274 ++++++++++++++++++
src/report/report-formatter-csv.h | 89 ++++++
src/report/report-formatter-html.cpp | 514 ++++++++++++++++++++++++++++++++++
src/report/report-formatter-html.h | 127 +++++++++
src/report/report-formatter-null.cpp | 179 ++++++++++++
src/report/report-formatter-null.h | 67 +++++
src/report/report-formatter.h | 63 ++++
src/report/report-maker.cpp | 331 ++++++++++++++++++++++
src/report/report-maker.h | 209 ++++++++++++++
11 files changed, 1858 insertions(+), 1 deletions(-)
create mode 100644 src/report/report-formatter-csv.cpp
create mode 100644 src/report/report-formatter-csv.h
create mode 100644 src/report/report-formatter-html.cpp
create mode 100644 src/report/report-formatter-html.h
create mode 100644 src/report/report-formatter-null.cpp
create mode 100644 src/report/report-formatter-null.h
create mode 100644 src/report/report-formatter.h
create mode 100644 src/report/report-maker.cpp
create mode 100644 src/report/report-maker.h
Hello,
- can we please avoid code duplication? for example, both html and csv
reporters contain identical implementations of
clear_result()/get_result()/add*() and friends.
- I think null formatter could be a basic class with default
implementation (null) of virtual functions, rather than separate
implementation of basic formatter interface (abstract class).
-ss