Re: [Powertop] [PATCH] do not implement get_user_input() in DISABLE_NCURSES builds
On (08/19/12 17:40), Arjan van de Ven wrote:
On 8/19/2012 2:57 PM, Sergey Senozhatsky wrote:
> do not implement get_user_input() in DISABLE_NCURSES builds
no offence.. but this ifdef madness needs to stop.
right now, powertop uses ncurses.
either we want to make it optional, but then this stuff needs to get a lot more modular,
or we just declare that you need ncurses.
I'm very much leaning towards the later fwiw...
I agree, and actually I don't like this patch (ifdef stuff also affects patches
I'm currently
working on). it's rather hard to tell how many people will be affected by #2 decision,
but we
can tell the number for #1 case.
DISABLE_NCURSES is not that nasty in overall, since it just disables some application
features,
comparing to, for example, DISABLE_TRYCATCH, which disables standard language features for
very
much non-obvious reason for someone with no embedded background.
that said, it'll be nice if we forbid DISABLE_NCURSES, but we'll still have ifdefs
in
code because of decisions different people made (like no ncurses in some distros or
incomplete/buggy
programming language support).
-ss