Re: [Powertop] [PATCH v2 02/19] main.cpp: append __TIME__ to --version output
On Thu, Aug 4, 2016 at 3:59 AM, Joe Konno <joe.konno(a)linux.intel.com> wrote:
From: Joe Konno <joe.konno(a)intel.com>
- printf(_("PowerTOP version " POWERTOP_VERSION ", compiled on
" __DATE__ "\n"));
+ printf(_("PowerTOP version " POWERTOP_VERSION ", compiled on
" __DATE__ " at " __TIME__ "\n"));
By the way, there is a
warning regarding reproducibility produced
during build of Debian package.
main.cpp:101:78: warning: macro "__DATE__" might prevent reproducible
builds [-Wdate-time]
printf(("PowerTOP version " POWERTOP_VERSION ", compiled on " __DATE_
"\n"));
^
I'm not aware whether powertop project cares about build
reproducibility, but in case you are, may be it's better to put
generation of timestamps in version string under some development
define (#ifdef DEVEL or something) —
https://reproducible-builds.org/docs/timestamps/.
--
Eugene "eSyr" Syromyatnikov
mailto:evgSyr@gmail.com
xmpp:eSyr@jabber.{ru|org}