Re: [Powertop] [PATCH] Make libpci dependency optional
On 7/18/2012 7:53 AM, Igor Zhbanov wrote:
+#ifndef DISABLE_PCI
end_pci_access();
+#endif /* !DISABLE_PCI */
this is the wrong way to do this.
the right way (similar to how the kernel does this, and earlier patches
to this list for this exact same thing did it), is to provide a dummy
end_pci_access().
randomly sprinking #ifdef's all over the code is a really bad idea.