Re: [Powertop] [PATCH] src/cpu/cpu.cpp: Add suffix `u` to `4294967295` to signify an unsigned number

On (02/02/13 23:19), Paul Menzel wrote: > Date: Sat, 2 Feb 2013 22:27:58 +0100 > > The C++ compiler > > $ g++ --version > g++-4.7.real (Debian 4.7.2-15) 4.7.2 > Copyright (C) 2012 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. > > reports the following warning. > > $ make > […] > CXX cpu/powertop-cpu.o > cpu/cpu.cpp:776:3: warning: this decimal constant is unsigned only in ISO C90 [enabled by default] > […] > > Adding the suffix to the constant gets rid of the warning [1]. > > [1] http://stackoverflow.com/questions/2347936/cant-get-rid-of-this-decimal-c... > --- > src/cpu/cpu.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/cpu/cpu.cpp b/src/cpu/cpu.cpp > index f875e45..401bade 100644 > --- a/src/cpu/cpu.cpp > +++ b/src/cpu/cpu.cpp > @@ -797,7 +797,7 @@ void perf_power_bundle::handle_trace_point(void *trace, int cpunr, uint64_t time > exit(-1); > } > > - if (val == 4294967295) > + if (val == 4294967295u) NACK. cpu_idle tracepoint defined as TP_PROTO(unsigned int state, unsigned int cpu_id) please use `== (unsigned int)-1', which is, by the way, more clear than 4294967295.