Re: [Powertop] [PATCH] do not implement get_user_input() in DISABLE_NCURSES builds

>>right now, powertop uses ncurses. >> >>either we want to make it optional, but then this stuff needs to get a lot more modular, >>or we just declare that you need ncurses. >>I'm very much leaning towards the later fwiw... >> >I agree, and actually I don't like this patch (ifdef stuff also affects patches I'm currently >working on). it's rather hard to tell how many people will be affected by #2 decision, but we >can tell the number for #1 case. > >DISABLE_NCURSES is not that nasty in overall, since it just disables some application features, >comparing to, for example, DISABLE_TRYCATCH, which disables standard language features for very >much non-obvious reason for someone with no embedded background. > >that said, it'll be nice if we forbid DISABLE_NCURSES, but we'll still have ifdefs in >code because of decisions different people made (like no ncurses in some distros or incomplete/buggy >programming language support). > > > -ss The only reason we allowed DISABLE_NCURSES in the first place, was to support android. If we don't want to support android out of the box, we can start removing the crude and android can patch PowerTOP within their distro if they wanted. All other ifdef's need to be scrutinized. -C